sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s4-libnet: Checkr return codes in samsync_ldb_handle_domain().

Browse Source 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
This commit is contained in:
Andreas Schneider 2012-12-14 17:02:48 +01:00 committed by Günther Deschner
parent 3000fc29c3
commit e3eaeb942b
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
source4/libnet/libnet_samsync_ldb.c
View File

@ -161,13 +161,22 @@ static NTSTATUS samsync_ldb_handle_domain(TALLOC_CTX *mem_ctx,
/* Update the domain sid with the incoming
* domain (found on LSA pipe, database sid may
* be random) */
samdb_msg_add_dom_sid(state->sam_ldb, mem_ctx,
msg, "objectSid", state->dom_sid[database]);
ret = samdb_msg_add_dom_sid(state->sam_ldb,
mem_ctx,
msg,
"objectSid",
state->dom_sid[database]);
if (ret != LDB_SUCCESS) {
return NT_STATUS_INTERNAL_ERROR;
}
} else {
/* Well, we will have to use the one from the database */
state->dom_sid[database] = samdb_search_dom_sid(state->sam_ldb, state,
state->base_dn[database],
"objectSid", NULL);
if (state->dom_sid[database] == NULL) {
return NT_STATUS_INTERNAL_ERROR;
}
}
if (state->samsync_state->domain_guid) {
@ -179,7 +188,10 @@ static NTSTATUS samsync_ldb_handle_domain(TALLOC_CTX *mem_ctx,
return status;
}
ldb_msg_add_value(msg, "objectGUID", &v, NULL);
ret = ldb_msg_add_value(msg, "objectGUID", &v, NULL);
if (ret != LDB_SUCCESS) {
return NT_STATUS_INTERNAL_ERROR;
}
}
} else if (database == SAM_DATABASE_BUILTIN) {
/* work out the builtin_dn - useful for so many calls its worth