1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-08 04:58:40 +03:00

smbd: let check_user_ok() construct ent->session_info in one coherent block

We should finish manipulating ent->session_info before filling
conn->session_info. And conn->session_info should be not be changed.

Use git show -U15.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
This commit is contained in:
Stefan Metzmacher 2018-05-03 15:04:30 +02:00
parent 0e7456d286
commit e469d6c730

View File

@ -240,6 +240,14 @@ static bool check_user_ok(connection_struct *conn,
return false;
}
if (admin_user) {
DEBUG(2,("check_user_ok: user %s is an admin user. "
"Setting uid as %d\n",
ent->session_info->unix_info->unix_name,
sec_initial_uid() ));
ent->session_info->unix_token->uid = sec_initial_uid();
}
/*
* It's actually OK to call check_user_ok() with
* vuid == UID_FIELD_INVALID as called from change_to_user_by_session().
@ -265,14 +273,6 @@ static bool check_user_ok(connection_struct *conn,
conn->read_only = readonly_share;
conn->share_access = share_access;
if (admin_user) {
DEBUG(2,("check_user_ok: user %s is an admin user. "
"Setting uid as %d\n",
conn->session_info->unix_info->unix_name,
sec_initial_uid() ));
conn->session_info->unix_token->uid = sec_initial_uid();
}
return(True);
}