sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Code

libcli:auth: Check return status of netlogon_creds_init_64bit()

Browse Source 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Andreas Schneider 2019-11-13 09:41:18 +01:00 committed by Andreas Schneider
parent 2c21cd6d49
commit e4ae1ba451
1 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
libcli/auth/credentials.c
View File

@ -51,10 +51,10 @@ static void netlogon_creds_step_crypt(struct netlogon_creds_CredentialState *cre
this call is made after the netr_ServerReqChallenge call
*/
static void netlogon_creds_init_64bit(struct netlogon_creds_CredentialState *creds,
const struct netr_Credential *client_challenge,
const struct netr_Credential *server_challenge,
const struct samr_Password *machine_password)
static NTSTATUS netlogon_creds_init_64bit(struct netlogon_creds_CredentialState *creds,
const struct netr_Credential *client_challenge,
const struct netr_Credential *server_challenge,
const struct samr_Password *machine_password)
{
uint32_t sum[2];
uint8_t sum2[8];
@ -68,6 +68,8 @@ static void netlogon_creds_init_64bit(struct netlogon_creds_CredentialState *cre
ZERO_ARRAY(creds->session_key);
des_crypt128(creds->session_key, sum2, machine_password->hash);
return NT_STATUS_OK;
}
/*
@ -458,7 +460,14 @@ struct netlogon_creds_CredentialState *netlogon_creds_client_init(TALLOC_CTX *me
return NULL;
}
} else {
netlogon_creds_init_64bit(creds, client_challenge, server_challenge, machine_password);
status = netlogon_creds_init_64bit(creds,
client_challenge,
server_challenge,
machine_password);
if (!NT_STATUS_IS_OK(status)) {
talloc_free(creds);
return NULL;
}
}
netlogon_creds_first_step(creds, client_challenge, server_challenge);
@ -624,8 +633,14 @@ struct netlogon_creds_CredentialState *netlogon_creds_server_init(TALLOC_CTX *me
return NULL;
}
} else {
netlogon_creds_init_64bit(creds, client_challenge, server_challenge,
machine_password);
status = netlogon_creds_init_64bit(creds,
client_challenge,
server_challenge,
machine_password);
if (!NT_STATUS_IS_OK(status)) {
talloc_free(creds);
return NULL;
}
}
netlogon_creds_first_step(creds, client_challenge, server_challenge);