sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

tldap: Make memcpy of no controls safe

Browse Source 
Static analyzers sometimes complain about this case.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14029
This commit is contained in:
Garming Sam 2019-07-31 01:08:23 +00:00 committed by Andrew Bartlett
parent 1a7f2a230d
commit e5452a3742
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source3/lib/tldap_util.c
View File

@ -588,7 +588,9 @@ struct tldap_control *tldap_add_control(TALLOC_CTX *mem_ctx,
if (result == NULL) { if (result == NULL) {
return NULL; return NULL;
} }
memcpy(result, ctrls, sizeof(struct tldap_control) * num_ctrls); if (num_ctrls > 0) {
memcpy(result, ctrls, sizeof(struct tldap_control) * num_ctrls);
}
result[num_ctrls] = *ctrl; result[num_ctrls] = *ctrl;
return result; return result;
} }