sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

lib/audit_logging fix flapping test

Browse Source 
Add an adjustment to the before and after values to cater for the
occasional differences between the calculated times.

The exact value of the time stamp is not important what is important is
that is correctly formatted and that the value is reasonable i.e. it's
close enough to the current time.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Gary Lockyer 2018-06-09 14:58:51 +02:00 committed by Andrew Bartlett
parent 81f7ecc2a7
commit e5c0e6da65
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/audit_logging/tests/audit_logging_test.c
View File

@ -219,6 +219,7 @@ static void test_json_add_timestamp(void **state)
time_t before;
time_t after;
time_t actual;
const int adjustment = 1;
object = json_new_object();
@ -255,7 +256,10 @@ static void test_json_add_timestamp(void **state)
/*
* The timestamp should be before <= actual <= after
* but we adjust the times to cater for any precision issues.
*/
before -= adjustment;
after += adjustment;
assert_true(difftime(actual, before) >= 0);
assert_true(difftime(after, actual) >= 0);