sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

r24462: - Removing all ACEs was causing removal of the DACL entirely. Win2000 ignored

Browse Source 
the request, presumably due to the PROTECTED flag not being set.  Setting
  that flag (in make_sec_desc()) has much wider implications than just to
  libsmbclient, so instead of modifying that, we'll remove security
  descriptors by setting the number of ACEs to zero.  At some point, we might
  want to look into whether we should actually be setting the PROTECTED flag
  in the DACL.

  Reference http://www.microsoft.com/technet/prodtechnol/windows2000serv/reskit/distrib/dsce_ctl_qxju.mspx?mfr=true

Derrell
(This used to be commit 319df380e5)
This commit is contained in:
Derrell Lipman 2007-08-15 13:44:44 +00:00 committed by Gerald (Jerry) Carter
parent 6051d51654
commit e60c0a5bff
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source3/libsmb/libsmbclient.c
View File

@ -5142,7 +5142,6 @@ cacl_set(TALLOC_CTX *ctx,
switch (mode) {
case SMBC_XATTR_MODE_REMOVE_ALL:
old->dacl->num_aces = 0;
old->dacl = NULL;
dacl = old->dacl;
break;
@ -5159,9 +5158,6 @@ cacl_set(TALLOC_CTX *ctx,
old->dacl->aces[k+1];
}
old->dacl->num_aces--;
if (old->dacl->num_aces == 0) {
old->dacl = NULL;
}
found = True;
dacl = old->dacl;
break;