sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-10-23 11:33:16 +03:00
Code Activity

libcli/auth: try to use the current timestamp creds->sequence

Browse Source 
If the last usage of netlogon_creds_client_authenticator()
is in the past try to use the current timestamp and increment
more than just 2.

If we use netlogon_creds_client_authenticator() a lot within a
second, we increment keep incrementing by 2.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Dec 24 13:18:18 CET 2013 on sn-devel-104
This commit is contained in:
Stefan Metzmacher
2013-12-17 19:55:12 +01:00
parent 636daac3b7
commit e6afeae695
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
libcli/auth/credentials.c
View File

@@ -344,7 +344,29 @@ struct netlogon_creds_CredentialState *netlogon_creds_client_init_session_key(TA
void netlogon_creds_client_authenticator(struct netlogon_creds_CredentialState *creds,
struct netr_Authenticator *next)
{
uint32_t t32n = (uint32_t)time(NULL);
/*
* we always increment and ignore an overflow here
*/
creds->sequence += 2;
if (t32n > creds->sequence) {
/*
* we may increment more
*/
creds->sequence = t32n;
} else {
uint32_t d = creds->sequence - t32n;
if (d >= INT32_MAX) {
/*
* got an overflow of time_t vs. uint32_t
*/
creds->sequence = t32n;
}
}
netlogon_creds_step(creds);
next->cred = creds->client;