sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-03 04:22:09 +03:00
Code Activity

r16979: - ntcancel should compare TID,UID,MID and PID

Browse Source 
- don't return ntcancel error, as we don't know how signing works
  for them

metze
(This used to be commit 20311e58d5)
This commit is contained in:
Stefan Metzmacher
2006-07-12 14:15:06 +00:00
committed by Gerald (Jerry) Carter
parent dd2d3b082c
commit e6b29409a2
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
source4/smb_server/smb/reply.c
View File

@ -2197,12 +2197,15 @@ void smbsrv_reply_ntcreate_and_X(struct smbsrv_request *req)
void smbsrv_reply_ntcancel(struct smbsrv_request *req) void smbsrv_reply_ntcancel(struct smbsrv_request *req)
{ {
struct smbsrv_request *r; struct smbsrv_request *r;
uint16_t tid = SVAL(req->in.hdr,HDR_TID);
uint16_t uid = SVAL(req->in.hdr,HDR_UID);
uint16_t mid = SVAL(req->in.hdr,HDR_MID); uint16_t mid = SVAL(req->in.hdr,HDR_MID);
uint16_t pid = SVAL(req->in.hdr,HDR_PID); uint16_t pid = SVAL(req->in.hdr,HDR_PID);
for (r = req->smb_conn->requests; r; r = r->next) { for (r = req->smb_conn->requests; r; r = r->next) {
if (tid != SVAL(r->in.hdr,HDR_TID)) continue;
if (uid != SVAL(r->in.hdr,HDR_UID)) continue;
if (mid != SVAL(r->in.hdr,HDR_MID)) continue; if (mid != SVAL(r->in.hdr,HDR_MID)) continue;
/* do we really need to check the PID? */
if (pid != SVAL(r->in.hdr,HDR_PID)) continue; if (pid != SVAL(r->in.hdr,HDR_PID)) continue;
SMBSRV_CHECK(ntvfs_cancel(r->ntvfs)); SMBSRV_CHECK(ntvfs_cancel(r->ntvfs));
@ -2212,8 +2215,12 @@ void smbsrv_reply_ntcancel(struct smbsrv_request *req)
return; return;
} }
/* TODO: workout the correct error code */ /* TODO: workout the correct error code,
smbsrv_send_error(req, NT_STATUS_FOOBAR); * until we know how the smb signing works
* for ntcancel replies, don't send an error
*/
/*smbsrv_send_error(req, NT_STATUS_FOOBAR);*/
talloc_free(req);
} }
/* /*