sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

pytest:samba-tool domain test policy: test SDDL diagnostics

Browse Source 
The existing 'bad SDDL' test has SDDL so bad that the diagnostics
are not exercised.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Nov  1 21:12:33 UTC 2023 on atb-devel-224
This commit is contained in:
Douglas Bagnall 2023-10-28 12:09:04 +13:00 committed by Andrew Bartlett
parent d915443ab0
commit e7f38c3a19
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
python/samba/tests/samba_tool/domain_auth_policy.py
View File

@ -297,6 +297,48 @@ class AuthPolicyCmdTestCase(BaseAuthCmdTest):
self.assertIn("Unable to parse SDDL", err)
self.assertIn(" *INVALID SDDL*\n ^\n unknown error", err)
def test_create__invalid_sddl_conditional_ace(self):
"""Test creating a new authentication policy with invalid SDDL in a field."""
sddl = "O:SYG:SYD:(XA;OICI;CR;;;WD;(Member_of {secret club}))"
result, out, err = self.runcmd("domain", "auth", "policy", "create",
"--name", "invalidSDDLPolicy2",
"--user-allowed-to-authenticate-from",
sddl)
self.assertEqual(result, -1)
self.assertIn("Unable to parse SDDL", err)
self.assertIn(sddl, err)
self.assertIn(f"\n{'^':>41}", err)
self.assertIn("unexpected byte 0x73 's' parsing literal", err)
self.assertNotIn(" File ", err)
def test_create__invalid_sddl_conditional_ace_non_ascii(self):
"""Test creating a new authentication policy with invalid SDDL in a field."""
sddl = 'O:SYG:SYD:(XA;OICI;CR;;;WD;(@User.āāēē == "łē¶ŧ¹⅓þōīŋ“đ¢ð»" && Member_of {secret club}))'
result, out, err = self.runcmd("domain", "auth", "policy", "create",
"--name", "invalidSDDLPolicy2",
"--user-allowed-to-authenticate-from",
sddl)
self.assertEqual(result, -1)
self.assertIn("Unable to parse SDDL", err)
self.assertIn(sddl, err)
self.assertIn(f"\n{'^':>76}\n", err)
self.assertIn(" unexpected byte 0x73 's' parsing literal", err)
self.assertNotIn(" File ", err)
def test_create__invalid_sddl_normal_ace(self):
"""Test creating a new authentication policy with invalid SDDL in a field."""
sddl = "O:SYG:SYD:(A;;;;ZZ)(XA;OICI;CR;;;WD;(Member_of {WD}))"
result, out, err = self.runcmd("domain", "auth", "policy", "create",
"--name", "invalidSDDLPolicy3",
"--user-allowed-to-authenticate-from",
sddl)
self.assertEqual(result, -1)
self.assertIn("Unable to parse SDDL", err)
self.assertIn(sddl, err)
self.assertIn(f"\n{'^':>12}", err)
self.assertIn("unknown error", err)
self.assertNotIn(" File ", err) # traceback marker
def test_create__already_exists(self):
"""Test creating a new authentication policy that already exists."""
result, out, err = self.runcmd("domain", "auth", "policy", "create",