sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-28 01:58:17 +03:00
Code

gencache: don't leak cache_path onto talloc tos

Browse Source 
Also check for allocation failures.

Reported-by: Franz Pförtsch <franz.pfoertsch@brose.com>
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
David Disseldorp 2014-10-06 18:21:13 +02:00 committed by Jeremy Allison
parent e4c27cb4bb
commit e8ee9bb66e
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source3/lib/gencache.c
View File

@ -65,6 +65,9 @@ static bool gencache_init(void)
if (cache) return True;
cache_fname = cache_path("gencache.tdb");
if (cache_fname == NULL) {
return false;
}
DEBUG(5, ("Opening cache file at %s\n", cache_fname));
@ -101,6 +104,7 @@ static bool gencache_init(void)
DEBUG(5, ("gencache_init: Opening cache file %s read-only.\n", cache_fname));
}
}
TALLOC_FREE(cache_fname);
if (!cache) {
DEBUG(5, ("Attempt to open gencache.tdb has failed.\n"));
@ -108,6 +112,11 @@ static bool gencache_init(void)
}
cache_fname = lock_path("gencache_notrans.tdb");
if (cache_fname == NULL) {
tdb_close(cache);
cache = NULL;
return false;
}
DEBUG(5, ("Opening cache file at %s\n", cache_fname));
@ -120,10 +129,12 @@ static bool gencache_init(void)
if (cache_notrans == NULL) {
DEBUG(5, ("Opening %s failed: %s\n", cache_fname,
strerror(errno)));
TALLOC_FREE(cache_fname);
tdb_close(cache);
cache = NULL;
return false;
}
TALLOC_FREE(cache_fname);
return True;
}