sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-12-20 16:23:51 +03:00
Code Activity

python:tests: Adopt safe_tarfile for extraction_filter raises

Browse Source 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15390

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
This commit is contained in:
Andreas Schneider
2023-06-06 16:06:57 +02:00
committed by Andrew Bartlett
parent 4952cb88e4
commit ebaa008162
1 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
python/samba/tests/safe_tarfile.py
View File

@@ -43,9 +43,16 @@ class SafeTarFileTestCase(TestCaseInTempDir):
stf = safe_tarfile.open(tarname)
self.assertRaises(tarfile.ExtractError,
stf.extractall,
tarname)
# We we have data_filter, we have a patched python to address
# CVE-2007-4559.
if hasattr(tarfile, "data_filter"):
self.assertRaises(tarfile.OutsideDestinationError,
stf.extractall,
tarname)
else:
self.assertRaises(tarfile.ExtractError,
stf.extractall,
tarname)
self.rm_files('x', 'tar.tar')
def test_slash(self):
@@ -60,8 +67,16 @@ class SafeTarFileTestCase(TestCaseInTempDir):
tf.close()
stf = safe_tarfile.open(tarname)
self.assertRaises(tarfile.ExtractError,
stf.extractall,
tarname)
# We we have data_filter, we have a patched python to address
# CVE-2007-4559.
if hasattr(tarfile, "data_filter"):
self.assertRaises(NotADirectoryError,
stf.extractall,
tarname)
else:
self.assertRaises(tarfile.ExtractError,
stf.extractall,
tarname)
self.rm_files('x', 'tar.tar')