sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-14 01:57:53 +03:00
Code

smbd: remove fd_close() from open_directory()

Browse Source 
fd_close() was accidentally added twice by
d00d09fdcf73a5839ae4f82cf8e953bb761bfbfb. If it would have been removed by
5770cdd7635a018817418f58bd37268aedebd6a9 that adds the reopen_from_procfd()
optimisation, all would be fine. But fd_close() still being called before
reopen_from_procfd() means we're closing the pathref fd prevening the
optimisation.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Ralph Boehme 2020-12-17 12:41:29 +01:00 committed by Jeremy Allison
parent de80649860
commit ebf37cfc3c
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source3/smbd/open.c
View File

@ -4639,11 +4639,6 @@ static NTSTATUS open_directory(connection_struct *conn,
}
}
status = fd_close(fsp);
if (!NT_STATUS_IS_OK(status)) {
return status;
}
/*
* Setup the files_struct for it.
*/