sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00
Code

pygpo: use correct method flags

Browse Source 
The METH_KEYWORDS argument must always be combined with METH_VARARGS.

In Python up to 3.7 this was checked at runtime, and as we had no callers to
get_unix_path() in Python we never noticed. In Python 3.8 it is checked at
import time, and everyone notices even if they aren't directly using GPOs.

Found and reported by Val Kulkov.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14209
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 12cccf3447333dfd4f5e437cd57ca5ec68724fdd)
This commit is contained in:
Douglas Bagnall 2019-12-03 11:17:26 +13:00 committed by Karolin Seeger
parent bbeb73b40b
commit edeed08a04
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libgpo/pygpo.c
View File

@ -117,7 +117,7 @@ out:
}
static PyMethodDef GPO_methods[] = {
{"get_unix_path", (PyCFunction)py_gpo_get_unix_path, METH_KEYWORDS,
{"get_unix_path", (PyCFunction)py_gpo_get_unix_path, METH_VARARGS | METH_KEYWORDS,
NULL },
{NULL}
};