From ee8dafa103bc55f58cccda0d0724cc919b42f91f Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Tue, 27 Jun 2023 17:01:28 +1200 Subject: [PATCH] s4-rpc_server/drsuapi: Update getnc_state to be != NULL This is closer to our READDME.Coding style BUG: https://bugzilla.samba.org/show_bug.cgi?id=15401 Signed-off-by: Andrew Bartlett Reviewed-by: Stefan Metzmacher (cherry picked from commit 2aba9e230ea62efcbd829f6f073894dfa3180c91) --- source4/rpc_server/drsuapi/getncchanges.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source4/rpc_server/drsuapi/getncchanges.c b/source4/rpc_server/drsuapi/getncchanges.c index 3e65c13f126..f932cb03131 100644 --- a/source4/rpc_server/drsuapi/getncchanges.c +++ b/source4/rpc_server/drsuapi/getncchanges.c @@ -2996,7 +2996,7 @@ allowed: } /* see if a previous replication has been abandoned */ - if (getnc_state) { + if (getnc_state != NULL) { struct ldb_dn *new_dn; ret = drs_ObjectIdentifier_to_dn_and_nc_root(getnc_state, sam_ctx, @@ -3025,7 +3025,7 @@ allowed: } } - if (getnc_state) { + if (getnc_state != NULL) { ret = drsuapi_DsReplicaHighWaterMark_cmp(&getnc_state->last_hwm, &req10->highwatermark); if (ret != 0) {