sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-28 01:58:17 +03:00
Code

ctdb-scripts: Avoid shellcheck warnings SC2030, SC2031 (subshell variables)

Browse Source 
SC2030: Modification of VAR is local (to subshell caused by (..) group).
SC2031: VAR was modified in a subshell. That change might be lost.

Fix a related, incorrect comment.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
This commit is contained in:
Martin Schwenke 2016-07-06 16:13:27 +10:00 committed by Amitay Isaacs
parent 0ea90f6170
commit efc9af2634
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ctdb/config/events.d/60.nfs
View File

@ -80,6 +80,9 @@ nfs_check_service ()
{
_progname="$1"
# This sub-shell is created to intentionally limit the scope of
# variable values read from the .check files.
# shellcheck disable=SC2030
(
# Subshell to restrict scope variables...
@ -166,7 +169,10 @@ nfs_check_service ()
) || exit 1
}
# Uses: stop_service, start_service, debug_stuck_threads
# Uses: service_stop_cmd, service_start_cmd, service_debug_cmd
# This function is called within the sub-shell that shellcheck thinks
# loses the above variable values.
# shellcheck disable=SC2031
nfs_restart_service ()
{
if [ -z "$service_stop_cmd" -o -z "$service_start_cmd" ] ; then