sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s4-libnet: Fix memory leak of lsa_RefDomainList and lsa_String onto libnet_ctx

Browse Source 
These are only needed for as long as the call, and should be children of the
private context.

This was found based on a log provided by Ricky Nance
<ricky.nance@weaubleau.k12.mo.us>.  Thanks Ricky!

Andrew Bartlett
This commit is contained in:
Andrew Bartlett 2012-08-31 12:38:41 +10:00
parent a5d57a04c2
commit efec5a9299
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source4/libnet/libnet_lookup.c
View File

@ -308,7 +308,7 @@ static bool prepare_lookup_params(struct libnet_context *ctx,
s->sids.count = 0;
s->sids.sids = NULL;
s->names = talloc_array(ctx, struct lsa_String, single_name);
s->names = talloc_array(s, struct lsa_String, single_name);
if (composite_nomem(s->names, c)) return false;
s->names[0].string = s->name;
@ -320,7 +320,7 @@ static bool prepare_lookup_params(struct libnet_context *ctx,
s->lookup.in.count = &s->count;
s->lookup.out.count = &s->count;
s->lookup.out.sids = &s->sids;
s->lookup.out.domains = talloc_zero(ctx, struct lsa_RefDomainList *);
s->lookup.out.domains = talloc_zero(s, struct lsa_RefDomainList *);
if (composite_nomem(s->lookup.out.domains, c)) return false;
return true;