sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Code

smbd: Save a few lines in smb2srv_open_lookup_replay_cache()

Browse Source 
Directly initialize variables, don't leave dangling pointers in TDB_DATA

Signed-off-by: Volker Lendecke <vl@samba.org>
This commit is contained in:
Volker Lendecke 2023-01-11 11:44:29 +01:00
parent 35a32171b5
commit f1a66267bc
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source3/smbd/smbXsrv_open.c
View File

@ -1034,10 +1034,10 @@ NTSTATUS smb2srv_open_lookup_replay_cache(struct smbXsrv_connection *conn,
NTSTATUS status;
struct smbXsrv_open_table *table = conn->client->open_table;
struct db_context *db = table->local.replay_cache_db_ctx;
struct GUID_txt_buf _create_guid_buf;
struct GUID_txt_buf tmp_guid_buf;
const char *create_guid_str = NULL;
TDB_DATA create_guid_key;
struct GUID_txt_buf _create_guid_buf;
const char *create_guid_str = GUID_buf_string(&create_guid, &_create_guid_buf);
TDB_DATA create_guid_key = string_term_tdb_data(create_guid_str);
struct db_record *db_rec = NULL;
struct smbXsrv_open *op = NULL;
struct smbXsrv_open_replay_cache rc = {
@ -1051,9 +1051,6 @@ NTSTATUS smb2srv_open_lookup_replay_cache(struct smbXsrv_connection *conn,
*_open = NULL;
create_guid_str = GUID_buf_string(&create_guid, &_create_guid_buf);
create_guid_key = string_term_tdb_data(create_guid_str);
db_rec = dbwrap_fetch_locked(db, frame, create_guid_key);
if (db_rec == NULL) {
TALLOC_FREE(frame);