sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00
Code

pthreadpool: add a comment about a further optimization in pthreadpool_tevent_job_destructor()

Browse Source 
This seems to be a really rare race, it's likely that the immediate
event will still trigger and cleanup.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
This commit is contained in:
Stefan Metzmacher 2018-06-22 17:22:10 +02:00 committed by Ralph Boehme
parent aa9b64eccf
commit f23cac39b3
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/pthreadpool/pthreadpool_tevent.c
View File

@ -491,6 +491,23 @@ static int pthreadpool_tevent_job_destructor(struct pthreadpool_tevent_job *job)
TALLOC_FREE(job->im);
}
/*
* TODO?: We could further improve this by adjusting
* tevent_threaded_schedule_immediate_destructor()
* and allow TALLOC_FREE() during its time
* in the main_ev->scheduled_immediates list.
*
* PTHREAD_TEVENT_JOB_THREAD_FENCE(job);
* if (state->needs_fence.signaled) {
* *
* * The signal function is completed
* * in future we may be allowed
* * to call TALLOC_FREE(job->im).
* *
* TALLOC_FREE(job->im);
* }
*/
/*
* pthreadpool_tevent_job_orphan() already removed
* it from pool->jobs. And we don't need try