sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Code

s3-torture Remove t_stringoverflow as fstrcpy now uses strlcpy

Browse Source 
Because we no longer use safe_strcpy() internally, we no longer have a
mode where we write to the end of the buffer in developer mode, and so
there isn't anything for this test to test.

Andrew Bartlett
This commit is contained in:
Andrew Bartlett 2011-10-26 17:30:45 +11:00
parent 9fe8c3db91
commit f28fda7638
2 changed files with 0 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source3/Makefile.in
View File

@ -3184,10 +3184,6 @@ bin/tdbtorture@EXEEXT@: $(BINARY_PREREQS) $(TDBTORTURE_OBJ) $(LIBTALLOC) $(LIBTD
@$(CC) -o $@ $(LDFLAGS) $(TDBTORTURE_OBJ) $(DYNEXP) \ @$(CC) -o $@ $(LDFLAGS) $(TDBTORTURE_OBJ) $(DYNEXP) \
$(LIBS) $(LIBTALLOC_LIBS) $(LIBTDB_LIBS) $(LIBS) $(LIBTALLOC_LIBS) $(LIBTDB_LIBS)
bin/t_stringoverflow@EXEEXT@: $(BINARY_PREREQS) bin/libbigballofmud.@SHLIBEXT@ torture/t_stringoverflow.o
$(CC) -o $@ $(DYNEXP) torture/t_stringoverflow.o \
-L./bin -lbigballofmud $(LIBWBCLIENT_LIBS)
bin/timelimit@EXEEXT@: script/tests/timelimit.o bin/timelimit@EXEEXT@: script/tests/timelimit.o
@echo Linking $@ @echo Linking $@
@$(CC) -o $@ $(DYNEXP) script/tests/timelimit.o @$(CC) -o $@ $(DYNEXP) script/tests/timelimit.o

23
source3/torture/t_stringoverflow.c
View File

@ -1,23 +0,0 @@
#include "includes.h"
int main(void)
{
char dest[100];
char *ptr = dest;
printf("running on valgrind? %d\n", RUNNING_ON_VALGRIND);
/* Try copying a string into an fstring buffer. The string
* will actually fit, but this is still wrong because you
* can't pstrcpy into an fstring. This should trap in a
* developer build. */
#if 0
/* As of CVS 20030318, this will be trapped at compile time! */
pstrcpy(dest, "hello");
#endif /* 0 */
fstrcpy(ptr, "hello!");
return 0;
}