sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-31 20:22:15 +03:00
Code Activity

samba-tool group addmembers: add new option --object-types

Browse Source 
With this option the admin can specify the object types of the group
members which will be added to the group. The search filter for the objects
will be created according to the types.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Ralph Boehme <slow@samba.org>
This commit is contained in:
Björn Baumbach
2019-08-09 17:07:07 +02:00
committed by Stefan Metzmacher
parent a4d77bfd90
commit f2e2579926
1 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
python/samba/netcmd/group.py
View File

@ -229,12 +229,27 @@ Example2 shows how to add a single user account, User2, to the supergroup AD gro
takes_options = [
Option("-H", "--URL", help="LDB URL for database or target server", type=str,
metavar="URL", dest="H"),
Option("--object-types",
help=("Comma separated list of object types.\n"
"The types are used to filter the search for the "
"specified members.\n"
"Valid values are: user, group, computer, serviceaccount, "
"contact and all.\n"
"Default: user,group,computer"),
default="user,group,computer",
type=str),
]
takes_args = ["groupname", "listofmembers"]
def run(self, groupname, listofmembers, credopts=None, sambaopts=None,
versionopts=None, H=None):
def run(self,
groupname,
listofmembers,
credopts=None,
sambaopts=None,
versionopts=None,
H=None,
object_types="user,group,computer"):
lp = sambaopts.get_loadparm()
creds = credopts.get_credentials(lp, fallback_machine=True)
@ -243,8 +258,10 @@ Example2 shows how to add a single user account, User2, to the supergroup AD gro
samdb = SamDB(url=H, session_info=system_session(),
credentials=creds, lp=lp)
groupmembers = listofmembers.split(',')
group_member_types = object_types.split(',')
samdb.add_remove_group_members(groupname, groupmembers,
add_members_operation=True)
add_members_operation=True,
member_types=group_member_types)
except Exception as e:
# FIXME: catch more specific exception
raise CommandError('Failed to add members "%s" to group "%s"' % (