sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00
Code

s3-rpc_client remove cli_auth_ntlmssp_data_destructor

Browse Source 
This can be an ordinary talloc child without causing any problem.

This seems to have been inherited from a time when ntlmssp_client_start()
returned malloc() based memory.

Andrew Bartlett
This commit is contained in:
Andrew Bartlett 2011-10-17 20:00:02 +11:00
parent 56328a4d61
commit f3333bdade
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
source3/rpc_client/cli_pipe.c
View File

@ -2256,12 +2256,6 @@ NTSTATUS rpccli_anon_bind_data(TALLOC_CTX *mem_ctx,
return NT_STATUS_OK; return NT_STATUS_OK;
} }
static int cli_auth_ntlmssp_data_destructor(struct pipe_auth_data *auth)
{
TALLOC_FREE(auth->auth_ctx);
return 0;
}
static NTSTATUS rpccli_ntlmssp_bind_data(TALLOC_CTX *mem_ctx, static NTSTATUS rpccli_ntlmssp_bind_data(TALLOC_CTX *mem_ctx,
enum dcerpc_AuthType auth_type, enum dcerpc_AuthType auth_type,
enum dcerpc_AuthLevel auth_level, enum dcerpc_AuthLevel auth_level,
@ -2289,7 +2283,7 @@ static NTSTATUS rpccli_ntlmssp_bind_data(TALLOC_CTX *mem_ctx,
goto fail; goto fail;
} }
status = auth_ntlmssp_client_start(NULL, status = auth_ntlmssp_client_start(result,
lp_netbios_name(), lp_netbios_name(),
lp_workgroup(), lp_workgroup(),
lp_client_ntlmv2_auth(), lp_client_ntlmv2_auth(),
@ -2298,8 +2292,6 @@ static NTSTATUS rpccli_ntlmssp_bind_data(TALLOC_CTX *mem_ctx,
goto fail; goto fail;
} }
talloc_set_destructor(result, cli_auth_ntlmssp_data_destructor);
status = auth_ntlmssp_set_username(ntlmssp_ctx, username); status = auth_ntlmssp_set_username(ntlmssp_ctx, username);
if (!NT_STATUS_IS_OK(status)) { if (!NT_STATUS_IS_OK(status)) {
goto fail; goto fail;