sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-29 15:42:04 +03:00
Code Activity

s4:ldap_server use talloc_unlink() to avoid talloc_free() with references

Browse Source 
Both the session_info and the ldb can have references.

Andrew Bartlett
This commit is contained in:
Andrew Bartlett
2010-08-18 10:00:40 +10:00
parent 23dc2e4244
commit f37793ef0a
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source4/ldap_server/ldap_bind.c
View File

@ -63,12 +63,12 @@ static NTSTATUS ldapsrv_BindSimple(struct ldapsrv_call *call)
result = LDAP_SUCCESS;
errstr = NULL;
talloc_free(call->conn->session_info);
talloc_unlink(call->conn, call->conn->session_info);
call->conn->session_info = session_info;
talloc_steal(call->conn, session_info);
/* don't leak the old LDB */
talloc_free(call->conn->ldb);
talloc_unlink(call->conn, call->conn->ldb);
status = ldapsrv_backend_Init(call->conn);
@ -234,11 +234,11 @@ static NTSTATUS ldapsrv_BindSASL(struct ldapsrv_call *call)
"SASL:[%s]: Failed to get session info: %s",
req->creds.SASL.mechanism, nt_errstr(status));
} else {
talloc_free(old_session_info);
talloc_unlink(conn, old_session_info);
talloc_steal(conn, conn->session_info);
/* don't leak the old LDB */
talloc_free(conn->ldb);
talloc_unlink(conn, conn->ldb);
status = ldapsrv_backend_Init(conn);