sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Code

fix crash bug in pidl generated client code, this

Browse Source 
could have happend with [in,out,unique] pointers
when the clients sends a valid pointer, but the server
reponse with a NULL pointer (as samba-3.0.26a do for some calls).

I've tested with midl to see how windows handles this situation
and also the reverse case where the client sends NULL and
the server reposnse with non-NULL.

It appears that midl generated code just ignores this
and only copies the result if both pointers are non-NULL.

Note: this is just cosmetic for the 3.0.x tree, as
rpccli_wkssvc_NetWkstaEnumUsers and rpccli_wkssvc_NetWkstaTransportEnum
are not used.

metze
This commit is contained in:
Stefan Metzmacher 2007-10-17 10:59:24 +02:00
parent d2a42b4b53
commit f37f19f817
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/librpc/gen_ndr/cli_wkssvc.c
View File

@ -102,10 +102,10 @@ NTSTATUS rpccli_wkssvc_NetWkstaEnumUsers(struct rpc_pipe_client *cli, TALLOC_CTX
/* Return variables */
*users = *r.out.users;
if ( entriesread ) {
if (entriesread && r.out.entriesread) {
*entriesread = *r.out.entriesread;
}
if ( totalentries ) {
if (totalentries && r.out.totalentries) {
*totalentries = *r.out.totalentries;
}
*resumehandle = *r.out.resumehandle;
@ -203,7 +203,7 @@ NTSTATUS rpccli_wkssvc_NetWkstaTransportEnum(struct rpc_pipe_client *cli, TALLOC
/* Return variables */
*level = *r.out.level;
*ctr = *r.out.ctr;
if ( totalentries ) {
if (totalentries && r.out.totalentries) {
*totalentries = *r.out.totalentries;
}
*resume_handle = *r.out.resume_handle;