sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-09 08:58:35 +03:00
Code

samba_upgradedns: Create binddns_dir if it doesn't already exist

Browse Source 
Without doing this, the upgrade process can fail if the directory is not
present, e.g. after restoring from an offline backup (which specifically
ignores this directory).

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
This commit is contained in:
Joseph Sutton 2021-05-26 13:44:15 +12:00 committed by Andrew Bartlett
parent c6b2846c9d
commit f5c26f7231
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source4/scripting/bin/samba_upgradedns
View File

@ -492,6 +492,10 @@ if __name__ == '__main__':
else:
logger.info("dns-%s account already exists" % hostname)
if not os.path.exists(paths.binddns_dir):
# This directory won't exist if we're restoring from an offline backup.
os.mkdir(paths.binddns_dir, 0o770)
private_dns_keytab_path = os.path.join(paths.private_dir, paths.dns_keytab)
bind_dns_keytab_path = os.path.join(paths.binddns_dir, paths.dns_keytab)