sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-04 08:22:08 +03:00
Code Activity

s4-ldap: removed an incorrect talloc_move()

Browse Source 
the parent of this session_info is either the stream_connection, or
its a system_session(). In either case reparenting it on the
ldapsrv_connection doesn't achieve anything that I can see.

The move was causing a steal on reference error because the
session_info often has multiple references.

Thanks to Metze for spotting this.

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Dec  1 22:10:42 CET 2010 on sn-devel-104
This commit is contained in:
Andrew Tridgell
2010-12-01 23:54:38 +11:00
parent 71e2d9e7e8
commit f5c5fd9e82
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
source4/ldap_server/ldap_server.c
View File

@ -330,7 +330,7 @@ static void ldapsrv_accept(struct stream_connection *c,
}
conn->server_credentials = server_credentials;
conn->session_info = talloc_move(conn, &session_info);
conn->session_info = session_info;
if (!NT_STATUS_IS_OK(ldapsrv_backend_Init(conn))) {
ldapsrv_terminate_connection(conn, "backend Init failed");