From f627be5ec2703cf3dbfc64a51b36904376aab361 Mon Sep 17 00:00:00 2001 From: Jim McDonough Date: Fri, 17 May 2002 13:13:15 +0000 Subject: [PATCH] Add an item about the __va_copy macro to prevent SEGV's on 390 and PPC Linux. (This used to be commit 443ba282be79e2b7259950fffbd7fe9bb4cabf8c) --- source3/CodingSuggestions | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/source3/CodingSuggestions b/source3/CodingSuggestions index 48c51281f52..1ff3e01c1ca 100644 --- a/source3/CodingSuggestions +++ b/source3/CodingSuggestions @@ -59,6 +59,11 @@ Here are some other suggestions: 6) explicitly add const qualifiers on parm passing in functions where parm is input only (somewhat controversial but const can be #defined away) +7) when passing a va_list as an arg, or assigning one to another, check + for HAVE_VA_COPY, and use it if it exists. + reason: on some platforms, va_list is a struct that must be + initialized in each function...can SEGV if you don't. + 8) discourage use of threads reason: portability (also see architecture.doc)