sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-08-03 04:22:09 +03:00
Code Activity

s3-utils: Correctly handle getenv() for the later system() call.

Browse Source 
The returned string of getenv() has an unknown size. You need to store
the result always in a char array with a certain size to make sure we
don't feed tainted data to the next function call.

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
This commit is contained in:
Andreas Schneider
2012-12-10 14:06:32 +01:00
committed by Günther Deschner
parent 34a18865d6
commit f670cae69d
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
source3/utils/interact.c
View File

@ -31,16 +31,19 @@
#include <termios.h>
static const char* get_editor(void) {
static const char* editor = NULL;
if (editor == NULL) {
editor = getenv("VISUAL");
if (editor == NULL) {
editor = getenv("EDITOR");
static char editor[64] = {0};
if (editor[0] == '\0') {
const char *tmp = getenv("VISUAL");
if (tmp == NULL) {
tmp = getenv("EDITOR");
}
if (editor == NULL) {
editor = "vi";
if (tmp == NULL) {
tmp = "vi";
}
snprintf(editor, sizeof(editor), "%s", tmp);
}
return editor;
}