sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-27 07:42:04 +03:00
Code Activity

samba-tool: moved takes_optiongroups definition to Command base class

Browse Source 
The option groups should be defined at the Command base class level as they are in common across all samba-tool commands.
Major move advantages:
1. more OOP approach
2. enforcing consistency across commands
3. avoiding the need of declaring for every new command

Signed-off-by: Andrew Tridgell <tridge@samba.org>
This commit is contained in:
Giampaolo Lauria
2011-07-15 12:07:03 -04:00
committed by Andrew Tridgell
parent 1dfcb019d2
commit f6fa868489
19 changed files with 23 additions and 240 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
source4/scripting/python/samba/netcmd/spn.py
View File

@ -3,6 +3,7 @@
# spn management
#
# Copyright Matthieu Patou mat@samba.org 2010
# Copyright Giampaolo Lauria 2011 <lauria2@yahoo.com>
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@ -56,12 +57,6 @@ class cmd_spn_list(Command):
"""List spns of a given user."""
synopsis = "%prog spn list <user>"
takes_optiongroups = {
"sambaopts": options.SambaOptions,
"credopts": options.CredentialsOptions,
"versionopts": options.VersionOptions,
}
takes_args = ["user"]
def run(self, user, credopts=None, sambaopts=None, versionopts=None):
@ -95,11 +90,6 @@ class cmd_spn_add(Command):
"""Create a new spn."""
synopsis = "%prog spn add [--force] <name> <user>"
takes_optiongroups = {
"sambaopts": options.SambaOptions,
"credopts": options.CredentialsOptions,
"versionopts": options.VersionOptions,
}
takes_options = [
Option("--force", help="Force the addition of the spn"\
" even it exists already", action="store_true"),
@ -153,12 +143,6 @@ class cmd_spn_delete(Command):
"""Delete a spn."""
synopsis = "%prog spn delete <name> [user]"
takes_optiongroups = {
"sambaopts": options.SambaOptions,
"credopts": options.CredentialsOptions,
"versionopts": options.VersionOptions,
}
takes_args = ["name", "user?"]
def run(self, name, user=None, credopts=None, sambaopts=None, versionopts=None):