mirror of
https://github.com/samba-team/samba.git
synced 2025-11-23 20:23:50 +03:00
r20098: Properly fix issues with create_token_from_username()
reported by James. Ensure that this function allocates everything on the temporary context except the return memory. Never call this with a null mem context, and now use conn->mem_ctx instead in smbd/service.c. Remove separate free functions for conn->ngroups and conn->nt_user_token as they are now always talloc'ed off the conn->mem_ctx. Future optimization will be to remove conn->mem_ctx and make all objects pointed to in the conn struct talloc'ed off conn itself. Easy to free then :-). Jeremy.
This commit is contained in:
committed by
Gerald (Jerry) Carter
parent
2c59c4dddc
commit
f83b6de44f
@@ -547,7 +547,7 @@ struct share_iterator {
|
||||
|
||||
typedef struct connection_struct {
|
||||
struct connection_struct *next, *prev;
|
||||
TALLOC_CTX *mem_ctx;
|
||||
TALLOC_CTX *mem_ctx; /* long-lived memory context for things hanging off this struct. */
|
||||
unsigned cnum; /* an index passed over the wire */
|
||||
struct share_params *params;
|
||||
BOOL force_user;
|
||||
|
||||
Reference in New Issue
Block a user