sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-24 13:57:43 +03:00
Code

account_pol: don't leak state_path onto talloc tos

Browse Source 
Also check for allocation failures.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
David Disseldorp 2014-11-02 20:21:27 +01:00 committed by Jeremy Allison
parent 30ab958f50
commit f88535e56e
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source3/passdb/account_pol.c
View File

@ -214,24 +214,32 @@ bool init_account_policy(void)
uint32_t version = 0;
int i;
NTSTATUS status;
char *db_path;
if (db != NULL) {
return True;
}
db = db_open(NULL, state_path("account_policy.tdb"), 0, TDB_DEFAULT,
db_path = state_path("account_policy.tdb");
if (db_path == NULL) {
return false;
}
db = db_open(NULL, db_path, 0, TDB_DEFAULT,
O_RDWR, 0600, DBWRAP_LOCK_ORDER_1, DBWRAP_FLAG_NONE);
if (db == NULL) { /* the account policies files does not exist or open
* failed, try to create a new one */
db = db_open(NULL, state_path("account_policy.tdb"), 0,
db = db_open(NULL, db_path, 0,
TDB_DEFAULT, O_RDWR|O_CREAT, 0600,
DBWRAP_LOCK_ORDER_1, DBWRAP_FLAG_NONE);
if (db == NULL) {
DEBUG(0,("Failed to open account policy database\n"));
TALLOC_FREE(db_path);
return False;
}
}
TALLOC_FREE(db_path);
status = dbwrap_fetch_uint32_bystring(db, vstring, &version);
if (!NT_STATUS_IS_OK(status)) {