sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-07 01:58:28 +03:00
Code

tdb: Factor out tdb_lock_covered_by_allrecord_lock from tdb_lock_list

Browse Source 
Reviewed-by: Rusty Russell <rusty@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
This commit is contained in:
Volker Lendecke 2012-12-14 09:21:42 +01:00 committed by Stefan Metzmacher
parent 26b8545df4
commit f8dafe5685
1 changed files with 31 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
lib/tdb/common/lock.c
View File

@ -334,36 +334,44 @@ static bool have_data_locks(const struct tdb_context *tdb)
return false;
}
/*
* A allrecord lock allows us to avoid per chain locks. Check if the allrecord
* lock is strong enough.
*/
static int tdb_lock_covered_by_allrecord_lock(struct tdb_context *tdb,
int ltype)
{
if (ltype == F_RDLCK) {
/*
* The allrecord_lock is equal (F_RDLCK) or stronger
* (F_WRLCK). Pass.
*/
return 0;
}
if (tdb->allrecord_lock.ltype == F_RDLCK) {
/*
* We ask for ltype==F_WRLCK, but the allrecord_lock
* is too weak. We can't upgrade here, so fail.
*/
tdb->ecode = TDB_ERR_LOCK;
return -1;
}
/*
* Asking for F_WRLCK, allrecord is F_WRLCK as well. Pass.
*/
return 0;
}
static int tdb_lock_list(struct tdb_context *tdb, int list, int ltype,
enum tdb_lock_flags waitflag)
{
int ret;
bool check = false;
/* a allrecord lock allows us to avoid per chain locks */
if (tdb->allrecord_lock.count) {
if (ltype == F_RDLCK) {
/*
* The allrecord_lock is equal (F_RDLCK) or stronger
* (F_WRLCK). Pass.
*/
return 0;
}
if (tdb->allrecord_lock.ltype == F_RDLCK) {
/*
* We ask for ltype==F_WRLCK, but the allrecord_lock
* is too weak. We can't upgrade here, so fail.
*/
tdb->ecode = TDB_ERR_LOCK;
return -1;
}
/*
* Asking for F_WRLCK, allrecord is F_WRLCK as well. Pass.
*/
return 0;
return tdb_lock_covered_by_allrecord_lock(tdb, ltype);
}
/* Only check when we grab first data lock. */