sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-07 17:18:11 +03:00
Code

idmap_hash: remember new domain sids in idmap_hash_sid_to_id()

Browse Source 
This change means that idmap_hash_id_to_sid() can return mappings
for new domains learned in idmap_hash_sid_to_id().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15319

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Mar 10 11:35:06 UTC 2023 on atb-devel-224

(cherry picked from commit 7ee725f286)
This commit is contained in:
Stefan Metzmacher 2019-03-21 16:54:31 +01:00 committed by Jule Anger
parent 750865aca3
commit f968514c4d
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
source3/winbindd/idmap_hash/idmap_hash.c
View File

@ -295,12 +295,11 @@ static NTSTATUS idmap_hash_sid_to_id(struct sid_hash_table *hashed_domains,
*/
if (netsamlogon_cache_have(&sid)) {
/*
* We keep the legacy behavior and
* just return the mapping, but
* the reverse mapping would not
* still not work.
* The domain is valid, so we'll
* remember it in order to
* allow reverse mappings to work.
*/
goto return_mapping;
goto remember_domain;
}
if (id->xid.type == ID_TYPE_NOT_SPECIFIED) {
@ -322,6 +321,17 @@ static NTSTATUS idmap_hash_sid_to_id(struct sid_hash_table *hashed_domains,
return NT_STATUS_OK;
}
/*
* Now we're sure the domain exist, remember
* the domain in order to return reverse mappings
* in future.
*/
remember_domain:
hashed_domains[h_domain].sid = dom_sid_dup(hashed_domains, &sid);
if (hashed_domains[h_domain].sid == NULL) {
return NT_STATUS_NO_MEMORY;
}
/*
* idmap_hash used to bounce back the requested type,
* which was ID_TYPE_UID, ID_TYPE_GID or