sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

pidl s4::Python: silence warnings

Browse Source 
- do not redeclare variables in the same scope.
- use $1 instead of \1, which perl just prefers.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2019-12-01 00:43:52 +13:00 committed by Andrew Bartlett
parent 51a11afecf
commit fbe402edf5
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pidl/lib/Parse/Pidl/Samba4/Python.pm
View File

@ -38,7 +38,7 @@ sub PrettifyTypeName($$)
{
my ($name, $basename) = @_;
$basename =~ s/^.*\.([^.]+)$/\1/;
$basename =~ s/^.*\.([^.]+)$/$1/;
$name =~ s/^$basename\_//;
@ -190,7 +190,6 @@ sub PythonElementGetSet($$$$$$) {
$self->indent;
$self->pidl("$cname *object = ($cname *)pytalloc_get_ptr(py_obj);");
my $mem_ctx = "pytalloc_get_mem_ctx(py_obj)";
my $l = $e->{LEVELS}[0];
my $nl = GetNextLevel($e, $l);
if ($l->{TYPE} eq "POINTER" and
not ($nl->{TYPE} eq "ARRAY" and ($nl->{IS_FIXED} or is_charset_array($e, $nl))) and
@ -1479,9 +1478,9 @@ sub Interface($$$)
$self->pidl("");
my $signature = "\"$interface->{NAME}_abstract_syntax()\\n\"";
$signature = "\"$interface->{NAME}_abstract_syntax()\\n\"";
my $docstring = $self->DocString($interface, $interface->{NAME}."_syntax");
$docstring = $self->DocString($interface, $interface->{NAME}."_syntax");
if ($docstring) {
$docstring = "$signature$docstring";