From fc13a1268a4a9de94efd312a8309aa55d331ae19 Mon Sep 17 00:00:00 2001 From: Noel Power Date: Fri, 7 Sep 2018 12:42:19 +0100 Subject: [PATCH] python/samba: PY3 port for ridalloc_exop test to work Signed-off-by: Noel Power Reviewed-by: Andrew Bartlett --- python/samba/dbchecker.py | 9 ++++----- python/samba/remove_dc.py | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/python/samba/dbchecker.py b/python/samba/dbchecker.py index 4459d77f02d..675c92e2205 100644 --- a/python/samba/dbchecker.py +++ b/python/samba/dbchecker.py @@ -1939,8 +1939,7 @@ newSuperior: %s""" % (str(from_dn), str(to_rdn), str(to_base))) raise else: instancetype |= dsdb.INSTANCE_TYPE_NC_ABOVE - - if self.write_ncs is not None and str(nc_root) in self.write_ncs: + if self.write_ncs is not None and str(nc_root) in [str(x) for x in self.write_ncs]: instancetype |= dsdb.INSTANCE_TYPE_WRITE return instancetype @@ -2060,10 +2059,10 @@ newSuperior: %s""" % (str(from_dn), str(to_rdn), str(to_base))) self.report("ERROR: Not fixing num_values(%d) for '%s' on '%s'" % (len(obj[attrname]), attrname, str(obj.dn))) else: - object_rdn_val = obj[attrname][0] + object_rdn_val = str(obj[attrname][0]) if str(attrname).lower() == 'isdeleted': - if obj[attrname][0] != "FALSE": + if str(obj[attrname][0]) != "FALSE": isDeleted = True if str(attrname).lower() == 'systemflags': @@ -2238,7 +2237,7 @@ newSuperior: %s""" % (str(from_dn), str(to_rdn), str(to_base))) if str(attrname).lower() == "instancetype": calculated_instancetype = self.calculate_instancetype(dn) - if len(obj["instanceType"]) != 1 or obj["instanceType"][0] != str(calculated_instancetype): + if len(obj["instanceType"]) != 1 or int(obj["instanceType"][0]) != calculated_instancetype: error_count += 1 self.err_wrong_instancetype(obj, calculated_instancetype) diff --git a/python/samba/remove_dc.py b/python/samba/remove_dc.py index 03cd5fdab9e..a6062703f24 100644 --- a/python/samba/remove_dc.py +++ b/python/samba/remove_dc.py @@ -237,7 +237,7 @@ def offline_remove_server(samdb, logger, computer_dn = None try: - dnsHostName = msgs[0]["dnsHostName"][0] + dnsHostName = str(msgs[0]["dnsHostName"][0]) except KeyError: dnsHostName = None @@ -268,7 +268,7 @@ def offline_remove_server(samdb, logger, samdb.delete(computer_dn, ["tree_delete:0"]) if "dnsHostName" in msgs[0]: - dnsHostName = msgs[0]["dnsHostName"][0] + dnsHostName = str(msgs[0]["dnsHostName"][0]) if remove_dns_account: res = samdb.search(expression="(&(objectclass=user)(cn=dns-%s)(servicePrincipalName=DNS/%s))" %