sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-29 15:42:04 +03:00
Code Activity

r19132: Fix some C++ warnings. Is there interest to have them in Samba4 as well?

Browse Source 
I have some problems resolving the last 3 ones in attrib_handlers.c. In line
251 the function ldb_dn_explode_casefold is called with mem_ctx as the first
argument. Looking at ldb_dn_explode_casefold I see that the first argument it
expects is a struct ldb_context. I could certainly add a cast to (struct
ldb_context *) to that call, but I would assume that this is the wrong fix. Is
it possible that attrib_handlers.c:251 and :254 should have ldb and not
mem_ctx as the first argument?

Can anybody from Samba4 clarify this for me and apply the correct fix?

Thanks a lot.

Volker
(This used to be commit 26f2cb71eb)
This commit is contained in:
Volker Lendecke
2006-10-06 14:39:47 +00:00
committed by Gerald (Jerry) Carter
parent d898cbce90
commit fd1cf23567
6 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
source3/lib/ldb/common/ldb.c
View File

@ -160,7 +160,7 @@ static const struct ldb_dn *ldb_set_default_basedn(struct ldb_context *ldb)
struct ldb_result *res;
struct ldb_dn *basedn=NULL;
basedn = ldb_get_opaque(ldb, "default_baseDN");
basedn = (struct ldb_dn *)ldb_get_opaque(ldb, "default_baseDN");
if (basedn) {
return basedn;
}
@ -182,7 +182,7 @@ static const struct ldb_dn *ldb_set_default_basedn(struct ldb_context *ldb)
const struct ldb_dn *ldb_get_default_basedn(struct ldb_context *ldb)
{
return ldb_get_opaque(ldb, "default_baseDN");
return (const struct ldb_dn *)ldb_get_opaque(ldb, "default_baseDN");
}
/*