1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00

source3/wscript: Announce deprecation of old Ceph version support

*at() variants for various libcephfs APIs were added with Ceph v17.x.
Any other version less than v17.x is soon to be considered EOL[1] which
we will now indicate with the help of a warning message during configure
time. Going further such a situation will result in disabling the module
altogether with the next major Samba version after v4.20.

[1] https://docs.ceph.com/en/latest/releases/#ceph-releases-index

Signed-off-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
This commit is contained in:
Anoop C S 2024-01-25 22:56:26 +05:30 committed by Günther Deschner
parent 858b1d064d
commit fe16ae1fe8

View File

@ -1679,16 +1679,19 @@ int main(void) {
conf.DEFINE('HAVE_CEPH', '1') conf.DEFINE('HAVE_CEPH', '1')
conf.CHECK_FUNCS_IN('ceph_select_filesystem', 'cephfs', conf.CHECK_FUNCS_IN('ceph_select_filesystem', 'cephfs',
headers='cephfs/libcephfs.h') headers='cephfs/libcephfs.h')
conf.CHECK_FUNCS_IN('ceph_mkdirat', 'cephfs', conf.DEFINE('HAVE_MANDATORY_CEPH_API', '1')
headers='cephfs/libcephfs.h') for api in ['ceph_mkdirat', 'ceph_openat', 'ceph_unlinkat',
conf.CHECK_FUNCS_IN('ceph_openat', 'cephfs', 'ceph_symlinkat', 'ceph_readlinkat']:
headers='cephfs/libcephfs.h') if not conf.CHECK_FUNCS_IN(api, 'cephfs',
conf.CHECK_FUNCS_IN('ceph_unlinkat', 'cephfs', headers='cephfs/libcephfs.h'):
headers='cephfs/libcephfs.h') conf.undefine('HAVE_MANDATORY_CEPH_API')
conf.CHECK_FUNCS_IN('ceph_symlinkat', 'cephfs', if not conf.env.HAVE_MANDATORY_CEPH_API:
headers='cephfs/libcephfs.h') Logs.warn("Installed Ceph version support is at the verge of "
conf.CHECK_FUNCS_IN('ceph_readlinkat', 'cephfs', "deprecation due to the absence of some mandatory "
headers='cephfs/libcephfs.h') "libcephfs APIs. This warning there shall result in "
"disabling the Ceph VFS module altogether with the "
"next major Samba version. It is highly recommended "
"to update to a more recent/active version of Ceph.")
else: else:
Logs.warn('''Ceph support disabled due to --without-acl-support Logs.warn('''Ceph support disabled due to --without-acl-support
or lack of ceph_statx support''') or lack of ceph_statx support''')