sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-28 01:58:17 +03:00
Code

s3: test: Add tests to show we still connect to a full_audit share with a bad success or fail VFS names.

Browse Source 
Add knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15098

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Jeremy Allison 2022-06-16 11:57:58 -07:00 committed by Andrew Bartlett
parent e752f841e6
commit fe78d3c014
4 changed files with 45 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
selftest/knownfail.d/full_audit_badname Normal file
View File

@ -0,0 +1,2 @@
^samba3.blackbox.test_full_audit_success_badname.Cannot\ connect\ to\ share\ full_audit_success_bad_name\(fileserver\)
^samba3.blackbox.test_full_audit_fail_badname.Cannot\ connect\ to\ share\ full_audit_fail_bad_name\(fileserver\)

8
selftest/target/Samba3.pm
View File

@ -3396,6 +3396,14 @@ sub provision($$)
[acls_non_canonical]
copy = tmp
acl flag inherited canonicalization = no
[full_audit_success_bad_name]
copy = tmp
full_audit:success = badname
[full_audit_fail_bad_name]
copy = tmp
full_audit:failure = badname
";
close(CONF);

29
source3/script/tests/test_bad_auditnames.sh Executable file
View File

@ -0,0 +1,29 @@
#!/bin/sh
# this tests a full audit share with bad VFS
# names will not allow connection.
# BUG: https://bugzilla.samba.org/show_bug.cgi?id=15098
if [ $# -lt 5 ]; then
cat <<EOF
Usage: $0 SERVER SHARE USERNAME PASSWORD SMBCLIENT
EOF
exit 1
fi
SERVER="$1"
SHARE="$2"
USERNAME="$3"
PASSWORD="$4"
SMBCLIENT="$5"
SMBCLIENT="$VALGRIND ${SMBCLIENT}"
incdir=$(dirname "$0")/../../../testprogs/blackbox
. "$incdir/subunit.sh"
can_connect()
{
$SMBCLIENT //"$SERVER"/"$SHARE" -U"$USERNAME"%"$PASSWORD" -c "ls" | grep "tree connect failed: NT_STATUS_UNSUCCESSFUL" >/dev/null 2>&1
}
testit "Cannot connect to share $SHARE" can_connect || failed=$((failed + 1))

6
source3/selftest/tests.py
View File

@ -670,6 +670,12 @@ for env in ["fileserver"]:
plantestsuite("samba3.blackbox.fifo", env,
[os.path.join(samba3srcdir, "script/tests/test_fifo.sh"),
'$SERVER', '$DOMAIN', 'gooduser', '$PASSWORD', '$PREFIX', env, smbclient3])
plantestsuite("samba3.blackbox.test_full_audit_success_badname", env,
[os.path.join(samba3srcdir, "script/tests/test_bad_auditnames.sh"),
'$SERVER', 'full_audit_success_bad_name', '$USERNAME', '$PASSWORD', smbclient3])
plantestsuite("samba3.blackbox.test_full_audit_fail_badname", env,
[os.path.join(samba3srcdir, "script/tests/test_bad_auditnames.sh"),
'$SERVER', 'full_audit_fail_bad_name', '$USERNAME', '$PASSWORD', smbclient3])
for env in ["fileserver:local"]:
plantestsuite("samba3.blackbox.net_usershare", env, [os.path.join(samba3srcdir, "script/tests/test_net_usershare.sh"), '$SERVER', '$SERVER_IP', '$USERNAME', '$PASSWORD', smbclient3])