sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Code

tdb_open_ex should always "goto fail" in case of error, rather than

Browse Source 
just returning.  I don't think this would leak at the moment, but it's
an accident waiting to happen.
This commit is contained in:
Martin Pool 0001-01-01 00:00:00 +00:00
parent bb6c0df4bc
commit fe901ec194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
source/tdb/tdb.c
View File

@ -1463,11 +1463,12 @@ TDB_CONTEXT *tdb_open_ex(char *name, int hash_size, int tdb_flags,
goto fail;
/* Is it already in the open list? If so, fail. */
if (tdb_already_open(st.st_dev, st.st_ino)
for (i = tdbs; i; i = i->next) {
if (i->device == st.st_dev && i->inode == st.st_ino) {
errno = EBUSY;
close(tdb->fd);
return NULL;
goto fail;
}
}