sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-03 13:47:25 +03:00
Code

s3:mdssvc: initialize the returned share_path with the empty string

Browse Source 
macOS returns the empty path for an unknown share. This paves the way for that
change. Currently we still fail the RPC request if the share is not known with
DCERPC_FAULT_CANT_PERFORM, but this is wrong and is going to be changed in the
next commit.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
This commit is contained in:
Ralph Boehme 2019-04-16 19:25:09 +02:00 committed by Jeremy Allison
parent c4b2dc95d5
commit fef3a4c75f
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source3/rpc_server/mdssvc/srv_mdssvc_nt.c
View File

@ -145,6 +145,7 @@ static NTSTATUS create_mdssvc_policy_handle(TALLOC_CTX *mem_ctx,
void _mdssvc_open(struct pipes_struct *p, struct mdssvc_open *r)
{
int snum;
char *outpath = discard_const_p(char, r->out.share_path);
char *path;
NTSTATUS status;
@ -153,6 +154,7 @@ void _mdssvc_open(struct pipes_struct *p, struct mdssvc_open *r)
*r->out.device_id = *r->in.device_id;
*r->out.unkn2 = *r->in.unkn2;
*r->out.unkn3 = *r->out.unkn3;
outpath[0] = '\0';
snum = lp_servicenumber(r->in.share_name);
if (!VALID_SNUM(snum)) {
@ -184,7 +186,7 @@ void _mdssvc_open(struct pipes_struct *p, struct mdssvc_open *r)
return;
}
strlcpy(discard_const_p(char, r->out.share_path), path, 1024);
strlcpy(outpath, path, 1024);
talloc_free(path);
}