sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-10-25 19:33:18 +03:00
Code Activity

lib: Fix a valgrind error

Browse Source 
See the comment inside

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
This commit is contained in:
Volker Lendecke
2014-07-09 13:51:06 +00:00
committed by Stefan Metzmacher
parent a017280ca5
commit ff53cde795
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
source3/lib/background.c
View File

@@ -181,7 +181,18 @@ static void background_job_waited(struct tevent_req *subreq)
if (written == -1) {
_exit(1);
}
TALLOC_FREE(state->msg);
/*
* No TALLOC_FREE here, messaging_parent_dgm_cleanup_init for
* example calls background_job_send with "messaging_context"
* as talloc parent. Thus "state" will be freed with the
* following talloc_free will have removed "state" when it
* returns. TALLOC_FREE will then write a NULL into free'ed
* memory. talloc_free() is required although we immediately
* exit, the messaging_context's destructor will want to clean
* up.
*/
talloc_free(state->msg);
_exit(0);
}