sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Code

s4-dsdb: use DLIST_ADD() not DLIST_ADD_END()

Browse Source 
Using DLIST_ADD_END() to construct a long list is very inefficient (it
is O(n^2). These lists are not ordered, so using DLIST_ADD() is much
better.
This commit is contained in:
Andrew Tridgell 2009-09-15 10:01:26 -07:00
parent 12f689eef4
commit ff8ad222cd
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source4/dsdb/schema/schema_init.c
View File

@ -967,7 +967,7 @@ int dsdb_schema_from_ldb_results(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
return LDB_ERR_CONSTRAINT_VIOLATION;
}
DLIST_ADD_END(schema->attributes, sa, struct dsdb_attribute *);
DLIST_ADD(schema->attributes, sa);
}
for (i=0; i < objectclass_res->count; i++) {
@ -988,7 +988,7 @@ int dsdb_schema_from_ldb_results(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
return LDB_ERR_CONSTRAINT_VIOLATION;
}
DLIST_ADD_END(schema->classes, sc, struct dsdb_class *);
DLIST_ADD(schema->classes, sc);
}
schema->fsmo.master_dn = ldb_msg_find_attr_as_dn(ldb, schema, schema_res->msgs[0], "fSMORoleOwner");

4
source4/dsdb/schema/schema_set.c
View File

@ -555,7 +555,7 @@ WERROR dsdb_set_schema_from_ldif(struct ldb_context *ldb, const char *pf, const
goto failed;
}
DLIST_ADD_END(schema->attributes, sa, struct dsdb_attribute *);
DLIST_ADD(schema->attributes, sa);
} else if (is_sc) {
struct dsdb_class *sc;
@ -569,7 +569,7 @@ WERROR dsdb_set_schema_from_ldif(struct ldb_context *ldb, const char *pf, const
goto failed;
}
DLIST_ADD_END(schema->classes, sc, struct dsdb_class *);
DLIST_ADD(schema->classes, sc);
}
}