sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
Code

s4:dns_server: loudly warn when a tombstone record has other records

Browse Source 
This shouldn't happen -- that is, there should never be non-tombstone
records in conjunction with a tombstone record -- and if it does, the
situation should resolve itself here. But the flow is confusing and
strange things sometimes happen often enough that it would be helpful
to know if this ever occurs.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
This commit is contained in:
Douglas Bagnall 2023-05-13 19:29:48 +12:00 committed by Andrew Bartlett
parent 78658eee76
commit ffdd9ddeae
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source4/dns_server/dnsserver_common.c
View File

@ -1034,6 +1034,11 @@ WERROR dns_common_replace(struct ldb_context *samdb,
* record.
*/
if (records[i].data.EntombedTime != 0) {
if (rec_count != 1) {
DBG_ERR("tombstone record has %u neighbour "
"records.\n",
rec_count - 1);
}
was_tombstoned = true;
}
continue;