3 Commits

Author	SHA1	Message	Date
Jeremy Allison	9fa95d5b45	lib: util: Finally remove possibilities of using sys_popen() unsafely. ... All code now uses sys_popenv() which is much harder to use incorrectly. Remove the extract_args() function that was the cause of possible issues. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2019-05-24 19:00:06 +00:00
Jeremy Allison	f20538de04	lib: popen: Prepare to remove sys_popen(). ... Add sys_popenv(char * const argl[]) that uses a NULL terminated vector array of args. Change sys_popen() to split up its command string and call sys_popenv(). Once all callers are converted to sys_popenv() we can remove sys_popen(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=13964 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2019-05-24 19:00:05 +00:00
Aliaksei Karaliou	65ea3f2a46	s3:util: Move popen wrappers to lib/util ... When linked into Samba3 libraries, sys_popen()/sys_pclose() cannot be used in lower level libraries because of circular dependencies. This patch moves them into common samba-util library. Signed-off-by: Aliaksei Karaliou <akaraliou@panasas.com> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>	2019-02-11 07:43:31 +01:00