1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-05 09:18:06 +03:00
Commit Graph

33 Commits

Author SHA1 Message Date
Joseph Sutton
44d03bf479 lib/torture: Don't overwrite test outcomes
If a test fails an assertion, and later calls torture_skip() to skip
part of the test, the TORTURE_SKIP result will overwrite the
TORTURE_FAIL result, and the overall outcome will be successful.

To avoid this, we now arrange possible outcomes in order of priority,
and ensure we always keep the higher priority one.

This reveals some failing tests.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
2023-04-12 13:52:32 +00:00
Stefan Metzmacher
0e0d89b55c lib/torture: fix subunit names of nested suites
E.g. passing 'smb2.multichannel.generic' to smbtorture results in

- interface_info
- num_channels

While passing 'smb2.multichannel' to smbtorture results in:

- generic.interface_info
- genetic.num_channels
- oplocks.test1
...
- leases.test1
...

Before we got this:

- interface_info
- num_channels
- test1
...
- test1

That made it impossible to add knownfail entries for

leases.test1 vs. oplocks.test1

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2020-07-07 10:30:40 +00:00
Stefan Metzmacher
a4a6c03bf8 lib/torture: add back links to the parent objects
This makes would allow the full name of a test to be constructed
if needed in future.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2020-07-07 10:30:39 +00:00
Stefan Metzmacher
f6eb56bff2 lib/torture: make torture_subunit_test_name() public
This makes it easier to modify.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2020-07-07 10:30:39 +00:00
Michael Adam
476672b647 dlist: remove unneeded type argument from DLIST_ADD_END()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-02-06 21:48:17 +01:00
Garming Sam
0f9b35d4d4 torture: NULL out after talloc_free
This appeared as a segmentation fault in rpc.spoolss.printer.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Dec 30 02:49:01 CET 2014 on sn-devel-104
2014-12-30 02:49:01 +01:00
Michael Adam
b760056f84 torture: fix whitespace/tab mixup in internal_torture_run_test()
No diff visible with "git show|diff -w".

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Sep  8 04:21:52 CEST 2014 on sn-devel-104
2014-09-08 04:21:52 +02:00
Jelmer Vernooij
a38e2cbbb3 libtorture: Improve suggestion to mention torture_assert_*() rather than
torture_result().
2012-05-03 18:28:05 +02:00
Jelmer Vernooij
1077337afb torture: Suggest torture_fail() / torture_result().
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu May  3 15:31:06 CEST 2012 on sn-devel-104
2012-05-03 15:31:06 +02:00
Andrew Bartlett
a1f04e8abc libcli/util Rename common map_nt_error_from_unix to avoid duplicate symbol
The two error tables need to be combined, but for now seperate the names.

(As the common parts of the tree now use the _common function,
errmap_unix.c must be included in the s3 autoconf build).

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Jun 20 08:12:03 CEST 2011 on sn-devel-104
2011-06-20 08:12:03 +02:00
Christian Ambach
2ba57fd183 s4:smbtorture do not leave output directory around
calling smbtorture with no or invalid arguments left the temporary
output directory around
this patches removes the dead-end exit from usage and makes the
logic go on until the final cleanup state is reached

output directory will still be left around when test times out
or testcases itself force an exit

also make sure that the directory itself is deleted, not just
the objects in it

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Feb 21 11:35:30 CET 2011 on sn-devel-104
2011-02-21 11:35:30 +01:00
Andrew Tridgell
11f5d7c2f5 s4-torture: not having an output dir is not a fatal error
just return NT_STATUS_OK, as nothing to cleanup

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-02-10 06:51:07 +01:00
Andrew Tridgell
261628d1e4 s4-torture: fixed uninitialised variable error
ret is uninitialised if the directory is empty
2010-10-13 11:00:04 +00:00
Matthieu Patou
77cdef5359 torture: Add debug on what we are removing 2010-10-11 13:46:21 +00:00
Andrew Bartlett
74ed86c4e3 lib/torture: Add function to clean up the output directory
This helps to avoid leaving 85MB of provision around for every
NET-API-BECOME-DC test.

Andrew Bartlett

Signed-off-by: Matthieu Patou <mat@matws.net>
2010-10-11 13:46:21 +00:00
Jelmer Vernooij
4b901f6d8b torture: Remove unused variable. 2010-09-23 11:36:12 -07:00
Jelmer Vernooij
136aa0d5ac smbtorture: Report times. 2010-09-22 22:29:09 -07:00
Jelmer Vernooij
0aff42a6e4 torture: Remove active_testname variable. 2010-09-21 22:54:34 -07:00
Jelmer Vernooij
e456c69498 torture: Fix running individual tests. 2010-09-21 22:54:34 -07:00
Jelmer Vernooij
49411fa107 subunit.pm: Pass through milliseconds in time reports. 2010-09-14 10:54:27 +02:00
James Peach
b7ad0c6e39 smbtorture: Emit correct test results if setup fails.
If the test setup fails, we still need to format the test result for the
UI. At leas in the subunit case, the format doesn't specify what to do
here, so we fail every test manually with the setup failure message.
2010-08-17 20:19:27 -07:00
Andrew Tridgell
6b266b85cf s4-loadparm: 2nd half of lp_ to lpcfg_ conversion
this converts all callers that use the Samba4 loadparm lp_ calling
convention to use the lpcfg_ prefix.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-16 18:24:27 +10:00
James Peach
9f69790355 smbtorture: Move interactive shell into a separate file. 2010-06-21 08:58:10 -07:00
Jelmer Vernooij
4fb98b6856 torture: Simplify torture suite running, call restricted test suite runner. 2010-04-10 22:38:32 +02:00
Jelmer Vernooij
31094b0e8c smbtorture: Report number of available tests in a testsuite using subunit. 2010-03-31 02:57:47 +02:00
Aravind Srinivasan
f7e3809d66 s4/torture: add a new ulong parameteric torture option 2009-11-17 17:06:26 -08:00
Jelmer Vernooij
54670bb400 Remove unused parameter setting. 2009-07-19 18:58:22 +02:00
Andrew Kroeger
71515ba190 s4: Call va_end() after all va_start()/va_copy() calls.
This corrects the issues reaised in bug #6129, and some others that were not
originally identified.  It also accounts for some code that was in the original
bug report but appears to have since been made common between S3 and S4.

Thanks to Erik Hovland <erik@hovland.org> for the original bug report.
2009-06-18 13:49:25 +10:00
Stefan Metzmacher
183c379fe5 s4:lib/tevent: rename structs
list=""
list="$list event_context:tevent_context"
list="$list fd_event:tevent_fd"
list="$list timed_event:tevent_timer"

for s in $list; do
	o=`echo $s | cut -d ':' -f1`
	n=`echo $s | cut -d ':' -f2`
	r=`git grep "struct $o" |cut -d ':' -f1 |sort -u`
	files=`echo "$r" | grep -v source3 | grep -v nsswitch | grep -v packaging4`
	for f in $files; do
		cat $f | sed -e "s/struct $o/struct $n/g" > $f.tmp
		mv $f.tmp $f
	done
done

metze
2008-12-29 20:46:40 +01:00
Tim Prouty
363fe11536 s3/s4 build: Fix "might be unitialized" warning 2008-11-20 18:04:42 -08:00
Jelmer Vernooij
ab55ecb881 Explicitly include samba4 includes.h to fix the build. 2008-11-18 01:35:10 +01:00
Jelmer Vernooij
8beecd42f2 Move torture directory to top-level. 2008-11-16 00:58:08 +01:00
Jelmer Vernooij
badfac4412 Move libtorture to top-level. 2008-11-16 00:55:35 +01:00