sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-05 09:18:06 +03:00
Code
137,152 Commits 60 Branches 1,144 Tags 452 MiB
v4-20-stable
Commit Graph

53 Commits

Author SHA1 Message Date
Douglas Bagnall
6a0daf6818 lib/torture: add assert_int_{less,greater} macros 
In some situations, like comparison functions for qsort, we don't care
about the actual value, just whethger it was greater or less than
zero.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 6159b098cf)
 2024-06-10 13:24:16 +00:00
Joseph Sutton
a56bf3fa26 lib/torture: Remove trailing whitespace 
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2023-12-08 02:28:33 +00:00
Günther Deschner
36745d63d6 s4-torture: add torture_assert_werr_equal_goto and torture_assert_werr_ok_goto macros 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2023-11-20 03:52:33 +00:00
Joseph Sutton
46f0c26965 lib/torture: Add torture_assert_size_*() macros 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15498

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2023-10-24 14:48:36 +00:00
Joseph Sutton
e933fd2dad lib/torture: Use portable format specifiers 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15498

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2023-10-24 14:48:36 +00:00
Joseph Sutton
44d03bf479 lib/torture: Don't overwrite test outcomes 
If a test fails an assertion, and later calls torture_skip() to skip
part of the test, the TORTURE_SKIP result will overwrite the
TORTURE_FAIL result, and the overall outcome will be successful.

To avoid this, we now arrange possible outcomes in order of priority,
and ensure we always keep the higher priority one.

This reveals some failing tests.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2023-04-12 13:52:32 +00:00
Ralph Boehme
8d58174cdd lib/torture: fix tctx arg usage in torture_assert_nttime_equal() macro 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2022-12-09 23:11:38 +00:00
Douglas Bagnall
d0d18934fa torture: add torture_assertf() 
Often we go 'torture_assert(tctx, expr, talloc_asprintf(tctx, "foo
%s", foo));' which is just a pain.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15040

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2022-06-17 01:28:30 +00:00
Stefan Metzmacher
0e0d89b55c lib/torture: fix subunit names of nested suites 
E.g. passing 'smb2.multichannel.generic' to smbtorture results in

- interface_info
- num_channels

While passing 'smb2.multichannel' to smbtorture results in:

- generic.interface_info
- genetic.num_channels
- oplocks.test1
...
- leases.test1
...

Before we got this:

- interface_info
- num_channels
- test1
...
- test1

That made it impossible to add knownfail entries for

leases.test1 vs. oplocks.test1

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2020-07-07 10:30:40 +00:00
Stefan Metzmacher
a4a6c03bf8 lib/torture: add back links to the parent objects 
This makes would allow the full name of a test to be constructed
if needed in future.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2020-07-07 10:30:39 +00:00
Stefan Metzmacher
f6eb56bff2 lib/torture: make torture_subunit_test_name() public 
This makes it easier to modify.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2020-07-07 10:30:39 +00:00
Stefan Metzmacher
8270b8c0b2 lib/torture: protect torture_assert[_goto]() with a do { } while(0) block 
This hopefully fixes a lot of coverity defects like:

Control flow issues  (DEADCODE)
Execution cannot reach this statement: ";".

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2019-09-10 17:38:40 +00:00
Ralph Boehme
4162ba78f8 lib:torture: add torture_assert_u32_[not_]equal[_goto] macros 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2019-08-08 20:24:32 +00:00
Ralph Boehme
323f852147 torture: add torture_assert_errno_equal_goto() 
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2019-08-07 06:07:28 +00:00
Andreas Schneider
a8f773e326 lib:torture: Fix string comparison macros where we directly pass NULL 
See e.g. lib/util/tests/strlist.c +177

Found by GCC 9.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2019-05-08 16:33:24 +00:00
Andreas Schneider
62ba14a41b lib:torture: Fix size type in torture macro 
Found by csbuild.
https://gitlab.com/samba-team/devel/samba/-/jobs/204481431

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2019-05-01 03:12:07 +00:00
Peter Somogyi
f0b85c1da2 s4/torture: make --unclist active with smb2 testcases 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12985

Signed-off-by: Peter Somogyi <psomogyi@hu.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Aug 30 00:16:51 CEST 2017 on sn-devel-144
 2017-08-30 00:16:51 +02:00
Ralph Boehme
60747c1be4 lib/torture: add two more ndr assert macros 
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12787

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
 2017-05-17 23:02:09 +02:00
Uri Simchoni
f31fd41ca7 torture: add torture_assert_mem_not_equal_goto() 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12715

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
 2017-03-26 19:42:16 +02:00
Ralph Boehme
49723151b2 lib/torture: add torture_assert_mem_equal_goto 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12427

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
 2017-03-02 00:32:22 +01:00
Andreas Schneider
9c0f2576d8 lib:torture: Make variables const 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12415

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-11-20 17:29:08 +01:00
Günther Deschner
fe84f8bab3 s4-torture: add new torture_assert_krb5_error_equal macro. 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2016-07-23 06:04:11 +02:00
Günther Deschner
cde8ed20e0 torture: show the first differing byte and a dump in torture_assert_data_blob_equal(). 
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Günther Deschner <gd@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2016-07-20 21:27:17 +02:00
Günther Deschner
c5c3f91c6f lib/torture: add torture_assert_u64_not_equal_goto macro 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-03-22 00:23:21 +01:00
Günther Deschner
04e1f2ea90 lib/torture: add torture_assert_hresult_{equal,ok} macros. 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2015-07-31 01:55:28 +02:00
Günther Deschner
e3cb9f721d lib/torture: be more verbose about ndr failures. 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
 2015-07-03 02:00:27 +02:00
Günther Deschner
6aeb0a08ab s4-torture: move torture_assert_sid_equal() out of ndr headers. 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
 2015-07-03 02:00:27 +02:00
Michael Adam
4de622b6b1 torture: add torture_assert_not_null[_goto] 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
 2015-03-30 13:41:26 +02:00
Michael Adam
bc858fda42 torture: add torture_assert_int_not_equal_goto 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
 2015-03-30 13:41:25 +02:00
Michael Adam
23cd60f0a3 torture: add torture_assert_u64_not_equal() 
Signed-off-by: Michael Adam <obnox@samba.org>
 2014-10-03 08:34:05 +02:00
Michael Adam
fae589be2a torture: add torture_assert_int_not_equal 
Signed-off-by: Michael Adam <obnox@samba.org>
 2014-10-03 08:34:05 +02:00
Gregor Beck
160ca49953 libtorture: factor out simple ui backend 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2012-09-21 16:26:39 +02:00
Günther Deschner
663c2b4f16 torture: add torture_assert_guid_equal() macro. 
Guenther
 2011-11-03 18:35:09 +01:00
Günther Deschner
2e2cb8d96d s4-smbtorture: add torture_assert_nttime_equal macro. 
Guenther
 2010-12-22 13:33:17 +01:00
Günther Deschner
28d618ddf0 s4-smbtorture: add torture_assert_strn_equal macro. 
Guenther
 2010-12-17 11:33:05 +01:00
Stefan Metzmacher
929063bb12 lib/torture: add torture_assert_u64_equal_goto() 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Dec  4 12:55:44 CET 2010 on sn-devel-104
 2010-12-04 12:55:44 +01:00
Andrew Bartlett
74ed86c4e3 lib/torture: Add function to clean up the output directory 
This helps to avoid leaving 85MB of provision around for every
NET-API-BECOME-DC test.

Andrew Bartlett

Signed-off-by: Matthieu Patou <mat@matws.net>
 2010-10-11 13:46:21 +00:00
Jelmer Vernooij
136aa0d5ac smbtorture: Report times. 2010-09-22 22:29:09 -07:00
Jelmer Vernooij
0aff42a6e4 torture: Remove active_testname variable. 2010-09-21 22:54:34 -07:00
Jelmer Vernooij
e456c69498 torture: Fix running individual tests. 2010-09-21 22:54:34 -07:00
James Peach
9f69790355 smbtorture: Move interactive shell into a separate file. 2010-06-21 08:58:10 -07:00
Jelmer Vernooij
4fb98b6856 torture: Simplify torture suite running, call restricted test suite runner. 2010-04-10 22:38:32 +02:00
Stefan Metzmacher
800c735de6 lib/torture: also print intergers as HEX values in the torture_assert macros 
metze
 2010-04-09 16:28:29 +02:00
Kamen Mazdrashki
ae30cb958e torture: add torture_assert_goto() convenience macro 2010-04-09 12:21:26 +03:00
Jelmer Vernooij
31094b0e8c smbtorture: Report number of available tests in a testsuite using subunit. 2010-03-31 02:57:47 +02:00
Andrew Tridgell
e73b790c04 fixed the build 
whoever pushed 15d93a5d8e, please check
that what you push compiles and passes tests. In this case it didn't
compile.
 2009-11-18 12:46:45 +11:00
Steven Danneman
5975ea793a s4/torture: add new torture_assert_*_todo() macros 
These allow torture tests to perform cleanup after a failure, by
jumping to a goto label.
 2009-09-08 13:43:06 -07:00
Jelmer Vernooij
54670bb400 Remove unused parameter setting. 2009-07-19 18:58:22 +02:00
Günther Deschner
68bb2d2e80 torture: minor fixes to torture macro text output. 
Guenther
 2009-06-02 13:12:09 +02:00
Stefan Metzmacher
183c379fe5 s4:lib/tevent: rename structs 
list=""
list="$list event_context:tevent_context"
list="$list fd_event:tevent_fd"
list="$list timed_event:tevent_timer"

for s in $list; do
	o=`echo $s | cut -d ':' -f1`
	n=`echo $s | cut -d ':' -f2`
	r=`git grep "struct $o" |cut -d ':' -f1 |sort -u`
	files=`echo "$r" | grep -v source3 | grep -v nsswitch | grep -v packaging4`
	for f in $files; do
		cat $f | sed -e "s/struct $o/struct $n/g" > $f.tmp
		mv $f.tmp $f
	done
done

metze
 2008-12-29 20:46:40 +01:00