1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-10 01:18:15 +03:00
Commit Graph

25979 Commits

Author SHA1 Message Date
Jelmer Vernooij
10441ed83d subunitrun: Use unittest.TestProgram if subunit.TestProgram is not
available.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Dec 10 03:49:03 CET 2010 on sn-devel-104
2010-12-10 03:49:03 +01:00
Jelmer Vernooij
636d8cfb42 s4-python: Add convenience function for forcibly importing bundled
package.
2010-12-10 03:04:06 +01:00
Jelmer Vernooij
bdf5a49cec subunitrun: Extend hack to cope with older system subunit run installs. 2010-12-10 03:04:06 +01:00
Jelmer Vernooij
b1daa50293 subunitrun: Remove global subunit module when reimporting from a
different location.
2010-12-10 03:04:06 +01:00
Jelmer Vernooij
8f4c064b49 s4-dist: Remove no longer existing files from blacklist (fixes 'make
dist' inclusion of configure)
2010-12-10 03:04:06 +01:00
Jelmer Vernooij
408a99e3bb s4-python: Fix use of bundled modules. 2010-12-10 03:04:06 +01:00
Jelmer Vernooij
4571b94e7b s4-python: Split up ensure_external_module. 2010-12-10 03:04:06 +01:00
Jelmer Vernooij
c565da0f71 selftest: Make sure system subunit.run has TestProgram. 2010-12-10 03:04:06 +01:00
Jelmer Vernooij
365cfb1c32 smbtorture: Rename --list to --list-suites, add stub --list. 2010-12-10 03:04:06 +01:00
Jelmer Vernooij
680a2fb517 s4-selftest: Add convenience function for running testsuites using
subunitrun.
2010-12-10 03:04:06 +01:00
Jelmer Vernooij
028ea57e55 selftest: Allow discovering tests in pure python testsuites. 2010-12-10 03:04:06 +01:00
Jelmer Vernooij
069ff146cb subunitrun: Support --list. 2010-12-10 03:04:06 +01:00
Jelmer Vernooij
e6974b0ff0 selftest: add --list option. 2010-12-10 03:04:06 +01:00
Matthieu Patou
8733738357 build: introduce SAMBA_CHECK_PYTHON_HEADERS
This function is a wrapper around waf's check_python_header.
It avoids searching more than once for the headers bringing a small
speed improvement and a better lisibility of the logs.

But it's mainly to avoid a nasty bug when python libraries are in path
pointed by python_LIBPL (ie. /usr/local/lib/python2.6/config/) instead
of python_LIBDIR (ie. /usr/local/lib).

On the first call waf will correctly find that in order to link with
python libs it needs to add -L$python_LIBPL.

But on the next calls of check_python_headers, waf will use both the
current library path value (ie. -L/usr/local/lib/python2.6/config) and
-L$python_LIBDIR (ie. /usr/local/lib/) which will make him beleive that
python libraries are in $python_LIBDIR which at the end will make the
final link test fails in check_python_headers as it will not use the
good directory.

So by avoiding calling check_python_headers more than once we avoid
making waf fooling itself.
2010-12-10 02:07:18 +03:00
Kai Blin
1f2518df5a s4 libcli: Add libcli_echo lib and torture test
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Thu Dec  9 23:57:03 CET 2010 on sn-devel-104
2010-12-09 23:57:03 +01:00
Kai Blin
9df1b408c1 s4: Implement UDP echo server example
This is a simple UDP-based echo server. It is mainly intended as an
example on how to do server service tasks in s4.
2010-12-09 23:01:57 +01:00
Stefan Metzmacher
5fcbb16760 s4:pyrpc_util: s/typename/type_name to avoid c++ warnings
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Dec  9 17:55:57 CET 2010 on sn-devel-104
2010-12-09 17:55:57 +01:00
Andrew Tridgell
57f2f1d72a waf: remove the restriction that private libraries must not have a vnum
we need the vnum for ABI checking for public libraries built as
private libraries when bundled

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Dec  9 12:47:41 CET 2010 on sn-devel-104
2010-12-09 12:47:40 +01:00
Andrew Bartlett
154b431093 s4-spnego Match Windows 2008, and no longer supply a name in the CIFS Negprot
Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Dec  9 08:50:28 CET 2010 on sn-devel-104
2010-12-09 08:50:27 +01:00
Andrew Bartlett
f681859eb8 s4-lsa Implement kerberos ticket life policy
We now no longer print tickets with a potentially infinite life, and
we report the same life over LSA as we use in the KDC.  We should get
this from group policy, but for now it's parametric smb.conf options.

Andrew Bartlett
2010-12-09 18:02:59 +11:00
Andrew Bartlett
22d67758ef s4-tests Workaround new default of 'client ntlmv2 auth = yes' in tests
The new default breaks some tests that were assuming LM or NTLM auth

Andrew Bartlett
2010-12-09 18:01:56 +11:00
Andrew Bartlett
54ee213fa5 s4-client Use NTLMv2 by default in the Samba4 client. 2010-12-09 18:01:56 +11:00
Andrew Tridgell
ebe2867fc2 waf-abi: auto-generate per-symbol versions from ABI files
This changes our version-script generation to use the ABI files that
are saved in git with each version number change of our public
libraries.

We use these ABI files to generate a linker version script that gives
the exact version number that each symbol was introduced. This
provides us with automatic fine grained symbol versioning.

Pair-Programmed-With: Jelmer Vernooij <jelmer@samba.org>
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-12-09 13:17:19 +11:00
Matthieu Patou
2771266def build: do not duplicate the checks for python in samba4
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Thu Dec  9 00:47:23 CET 2010 on sn-devel-104
2010-12-09 00:47:23 +01:00
Stefan Metzmacher
cfef64a5b0 s4:ldb: add ABI/ldb-0.9.20.sigs
metze
2010-12-08 19:07:16 +01:00
Stefan Metzmacher
65965566d2 s4:ldb: build libldb and pyldb-util as private libraries when building for samba4
This matches the behavior of the talloc and tdb builds.

metze
2010-12-08 19:07:15 +01:00
Stefan Metzmacher
63574fda0e s4:python: add PyString_FromStringOrNULL() to pyrpc_util
metze
2010-12-08 19:06:52 +01:00
Matthieu Patou
02f3567814 smbtorture: use xxxULL notation instead of INT64_C(xxx)
The first one is portable the second not always

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Wed Dec  8 15:48:10 CET 2010 on sn-devel-104
2010-12-08 15:48:10 +01:00
Nadezhda Ivanova
bf7b026a9a s4-acl: Replaced talloc_reference with talloc_steal, as aclread is the only one using this result message.
No need to reference as no one further up the stack uses the result, it is the result of a secondary request sent by aclread.

As a result from code review by Kamen Mazdrashki and Anatoliy Atanasov

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Wed Dec  8 15:01:51 CET 2010 on sn-devel-104
2010-12-08 15:01:51 +01:00
Jelmer Vernooij
623c93c8ba ldb: bump version number after introduction of new constant. 2010-12-08 13:32:18 +01:00
Nadezhda Ivanova
f85089e015 s4-acl: Fixed incorrect value of LDB_FLAG_INTERNAL_INACCESSIBLE_ATTRIBUTE
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Wed Dec  8 13:31:48 CET 2010 on sn-devel-104
2010-12-08 13:31:48 +01:00
Andrew Tridgell
735c1cd2da s4-pkgconfig: add @LIB_RPATH@ to our link flags
this is only set when rpath is used on install. It ensures that
applications that link against Samba libraries get the rpath right

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Dec  8 12:46:00 CET 2010 on sn-devel-104
2010-12-08 12:46:00 +01:00
Andrew Tridgell
af1b098441 s4-ldb: added @LIB_RPATH@ to the ldb pc file 2010-12-08 12:01:25 +01:00
Nadezhda Ivanova
2079a6d110 s4-acl: Changed the mechanism of attribute removal to speed it up.
Instead of using ldb_msg_remove_attr, now we are flagging the attributes to be removed,
and allocating the new elements array to be returned at once. This seems to decrease the
overhead by 50 percent.

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Wed Dec  8 12:00:27 CET 2010 on sn-devel-104
2010-12-08 12:00:27 +01:00
Nadezhda Ivanova
fe98b9aaeb s4-acl: Added a flag to mark an element as failing an access check. 2010-12-08 12:14:23 +02:00
Andrew Bartlett
8dd3013208 s4-param Allow +foo syntax in smb.conf list parsing
The idea here is to allow an smb.conf file to work from the defaults,
rather than override them.  For example, 'server services = +openchange'.

Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Dec  8 09:39:06 CET 2010 on sn-devel-104
2010-12-08 09:39:06 +01:00
Andrew Bartlett
94f4929e04 s4-spnego use "not_defined_in_RFC4178@please_ignore" if no principal specified
We need to make this the default, but for now just send it if we have
not been given a target principal.

Andrew Bartlett
2010-12-08 08:55:04 +01:00
Andrew Bartlett
a21cb5a0a1 libcli/auth bring ADS_IGNORE_PRINCIPAL in common 2010-12-08 08:55:04 +01:00
Andrew Tridgell
4debe69b73 s4-heimdal: enable symbol versioning in heimdal
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Pair-Programmed-With: Jelmer Vernooij <jelmer@samba.org>
2010-12-08 05:26:06 +01:00
Andrew Tridgell
84ac1f8f6a s4-dns: dlz_bind9 doesn't need to link to gensec any more
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-12-08 05:26:06 +01:00
Andrew Tridgell
d5bf525591 s4-waf: get the version number right on private libraries
use the first digit of the version number for the library version

Pair-Programmed-With: Jelmer Vernooij <jelmer@samba.org>
2010-12-08 05:26:06 +01:00
Andrew Tridgell
18177f1e52 s4-dns: use ldb hooks for samba extensions in dlz_bind9
this avoids linking dlz_bind9 directly to heimdal, which allows a
RTLD_DEEPBIND in ldb module loading to find the right kerberos version

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-12-08 05:26:06 +01:00
Andrew Tridgell
cba73975c2 s4-ldb: use RTLD_DEEPBIND if available for ldb modules
this allows us to avoid issues with ldb using heimdal while an
application using ldb using MIT kerberos

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-12-08 05:26:05 +01:00
Andrew Tridgell
591e18a12c s4-dns: allow a remote ldap server to be used with dlz_bind9
this allows for configs like this:

dlz "Samba zone" {
	database "dlopen /usr/lib/samba/modules/bind9/dlz_bind9.so
	-H ldap://10.0.0.4 -Uadministrator@v2.tridgell.net%penguin -k no";
};
2010-12-08 05:26:05 +01:00
Andrew Tridgell
be53dcd8bc s4-dsdb: register samba handlers in dsdb module 2010-12-08 05:26:05 +01:00
Andrew Tridgell
1b016f58ce s4-ldb: ensure ldb_register_samba_handlers() is not done twice
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-12-08 05:26:05 +01:00
Andrew Tridgell
545932fda5 samba-tools: more reasonable defaults for samba-tool commands
- fallback to machine account where possible

- default to local hostname where this is reasonable
2010-12-08 05:26:05 +01:00
Andrew Tridgell
249afc8906 samba-tools: export doesn't need any credentials
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-12-08 05:26:05 +01:00
Andrew Bartlett
d7cd2ad438 s4-provision Always run slaptest to convert the config file
If the directory exists, it does not mean that it is configured - we
may be on a re-run of the provision.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Dec  8 05:19:12 CET 2010 on sn-devel-104
2010-12-08 05:19:12 +01:00
Andrew Bartlett
87e2d68305 s4-provision Add an invalid names check for 'domain == netbiosname'
(This is also invalid)

Andrew Bartlett
2010-12-08 14:15:37 +11:00
Matthias Dieter Wallnöfer
055a3e0fae s4:libnet_samsync_ldb.c - simplify a talloc steal call
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Dec  7 16:05:30 CET 2010 on sn-devel-104
2010-12-07 16:05:30 +01:00
Matthias Dieter Wallnöfer
a07d20821a s4:libnet_samsync_ldb.c - introduce an error message on failed domain synchronisation 2010-12-07 15:19:14 +01:00
Nadezhda Ivanova
ec97c9f7c7 s4-acl: Remove unused variables from aclread module.
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Mon Dec  6 16:48:35 CET 2010 on sn-devel-104
2010-12-06 16:48:34 +01:00
Matthias Dieter Wallnöfer
15a2eff516 s4:acl_read LDB module - fix attributes list
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Dec  6 15:11:44 CET 2010 on sn-devel-104
2010-12-06 15:11:44 +01:00
Nadezhda Ivanova
91bf9133a6 s4-acl: Some optimisation of the aclread module
Modified the aclread module to now insert the attributes needed to perform access checks in the same request,
instead of doind a separate search per entry. Also, instanceType is now used to determine id the object has a parent
instead of parentGUID, which saves one additional search in operational.

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Mon Dec  6 13:50:19 CET 2010 on sn-devel-104
2010-12-06 13:50:19 +01:00
Nadezhda Ivanova
3f1b153132 s4-acl: Moved aclread module below descriptor and acl.
The aclread needs to be belod descriptor, as it needs to have the full nTsecurityDescriptor to make the
checks, and the descriptor module may filter out parts of it if SD_FLAGS_CONTROL is provided.
2010-12-06 14:00:38 +02:00
Matthias Dieter Wallnöfer
2664a67c86 s4:torture/locktest.c - fix "pid_t" printf warning on Solaris
According to "http://www.ibm.com/developerworks/linux/library/l-solar/"
it's generally a 32bit "int" - therefore this cast should fit.
2010-12-06 11:28:59 +01:00
Matthias Dieter Wallnöfer
3b7e2ee5e4 s4:torture/locktest.c - fix one indentation 2010-12-06 11:28:59 +01:00
Matthias Dieter Wallnöfer
0c8cf666fc s4:client/client.c - fix Solaris warning by a type cast 2010-12-06 11:28:58 +01:00
Matthias Dieter Wallnöfer
93d85ca5fd s4:fix some shadowed declaration warnings on Solaris by renaming the symbols 2010-12-06 11:28:58 +01:00
Andrew Tridgell
5845cc94a9 s4-dns: return the correct TTL
I've now patched the bind9 sdlz layer to cope with multiple TTLS on a
name/type pair

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Dec  6 08:12:11 CET 2010 on sn-devel-104
2010-12-06 08:12:11 +01:00
Andrew Tridgell
49e0aef3cb s4-dns: support Samba command line options to the dlz_bind.so module
this allows setting of Samba command line options in named.conf
2010-12-06 17:24:52 +11:00
Andrew Tridgell
c60ce7503c s4-dns: added flags support for dlz_bind9
this will allow us to set the THREADSAFE flag if we make this
threadsafe. For now we don't set that flag, and let bind9 do the
locking for us.
2010-12-06 17:24:52 +11:00
Andrew Tridgell
9f6f1b0098 s4-dns: a dlz module for bind9
this module can be loaded into bind9 if bind9 has been built with the
--with-dlz-dlopen option. It provides access bind9 access to the
DNS records in SAMDB.

You can then start bind9 with this in named.conf:

dlz "Samba zone" {
	database "dlopen /usr/lib/samba/modules/bind9/dlz_bind9.so";
};

See http://git.samba.org/tridge/bind9.git for a bind9 tree with the
dlz_dlopen driver. See also the discussion on the bind-workers mailing
list

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Dec  6 05:48:30 CET 2010 on sn-devel-104
2010-12-06 05:48:30 +01:00
Kamen Mazdrashki
af5649d5f8 s4-repl_meta_data: Print function name when we can't find attribute in Schema cache
Same error message is printed by linked_attributes.c module
and it was really hard to tell where the error occurred

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Mon Dec  6 00:05:59 CET 2010 on sn-devel-104
2010-12-06 00:05:59 +01:00
Kamen Mazdrashki
05e77f52d7 s4-linked_attributes: Give more info where an error occured
We have exact same error messages at different locations
and it is little bit hard to tell where the error came from
from the log.
2010-12-06 00:18:48 +02:00
Kamen Mazdrashki
be0a2a6891 s4-repl_meta_data: Remove duplicated check 2010-12-06 00:18:47 +02:00
Kamen Mazdrashki
be27a9dc42 s4-schema_load: Strip a pointless check
If *schema is NULL, then dsdb_schema_from_ldb_results()
call should have failed
2010-12-06 00:18:47 +02:00
Matthias Dieter Wallnöfer
55dba7bd16 s4:cluster/cluster.h - fix another gcc 3.4 "struct" warning
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Dec  5 21:22:18 CET 2010 on sn-devel-104
2010-12-05 21:22:18 +01:00
Matthias Dieter Wallnöfer
84c95bf88e s4:dsdb/samdb/ldb_modules/util.h - fix a gcc 3.4 compile warning 2010-12-05 20:28:44 +01:00
Matthias Dieter Wallnöfer
67318d18c1 s4:lib/messaging/*.h - fix compile warnings on gcc 3.4
For example on OpenSolaris
2010-12-05 20:24:18 +01:00
Jelmer Vernooij
71671a84bb s4-python: Add more module docstrings. 2010-12-05 17:27:05 +01:00
Jelmer Vernooij
52d64c53b9 s4-python: Add some more module docstrings. 2010-12-05 17:27:05 +01:00
Matthias Dieter Wallnöfer
536622e7d1 s4:dsdb/samdb/cracknames.c - fix another memory leak
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Dec  4 17:26:39 CET 2010 on sn-devel-104
2010-12-04 17:26:39 +01:00
Matthias Dieter Wallnöfer
f156c340b4 s4:kdc/kpasswdd.c - fix memory leaks 2010-12-04 16:40:25 +01:00
Matthias Dieter Wallnöfer
f1db3c52de s4:auth/gensec/gensec_krb5.c - fix/reorder memory free operations
To prevent memory leaks
2010-12-04 16:40:25 +01:00
Matthias Dieter Wallnöfer
ee311beabe s4:auth/gensec/gensec_krb5.c - remove a pointless "nt_status" test
There is no operation which sets the "nt_status" before the "if".
2010-12-04 16:40:25 +01:00
Matthias Dieter Wallnöfer
3fb5ae600e s4:auth/kerberos/kerberos_pac.c - fix another memory leak regarding the KRB principal
In addition fix a counter type

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Dec  4 15:14:46 CET 2010 on sn-devel-104
2010-12-04 15:14:46 +01:00
Matthias Dieter Wallnöfer
f92055f298 s4:dsdb/common/util_samr.c and auth/sam.c - fix error message 2010-12-04 14:27:40 +01:00
Stefan Metzmacher
69ad3f7f90 tls_tstream: use a dynamic buffer for the push case
Some versions of gnutls doesn't handle EAGAIN correctly,
so we better allow sending buffers without a low size limitation,
the limit is now UINT16_MAX (0xFFFF) and we allocate the buffer
with talloc each time.

metze
2010-12-04 12:12:21 +01:00
Matthieu Patou
a42ccab929 tls_tstream: increase the buffer size
The problem is that with certain version of gnutls are not working
properly if the server is sending in different packet things like (at
least)

* Certificate
* Server Key exchange
* Client certificate

Somehow it really expect this to be done in one packet as some
structures used _gnutls_send_handshake are reinitialized at every
packet exchange and intermediate steps didn't expect it

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-12-04 12:12:21 +01:00
Matthias Dieter Wallnöfer
14d3027458 s4:samr RPC server - dcesrv_samr_GetBootKeyInformation - return NOT_SUPPORTED
Windows Server 2008 does this

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Dec  4 12:11:47 CET 2010 on sn-devel-104
2010-12-04 12:11:47 +01:00
Matthias Dieter Wallnöfer
b6750eee28 s4:dsdb/common/util_samr.c - "dsdb_enum_group_mem" - fix it up regarding non SAM members
For example contacts.
2010-12-04 11:24:44 +01:00
Matthias Dieter Wallnöfer
b604e9425b s4:torture/rpc/samr.c - fix output message 2010-12-04 10:07:25 +01:00
Matthias Dieter Wallnöfer
88a2ad28fe s4/kdc - fix a warning regarding a changed parameter type (kvno)
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Dec  3 23:56:15 CET 2010 on sn-devel-104
2010-12-03 23:56:15 +01:00
Matthias Dieter Wallnöfer
70eaa3fd0c s3/s4:lsa.idl - QueryDomainInformationPolicy - the "unknown6" field is called "reserved"
MS-LSAD 3.1.1.1 - http://msdn.microsoft.com/en-us/library/cc234319(v=PROT.13).aspx
2010-12-03 22:56:19 +01:00
Matthias Dieter Wallnöfer
d0b3932447 s4:lsa RPC server - always initialise "info" structures
This should help to fix bug #7769
2010-12-03 22:47:21 +01:00
Matthias Dieter Wallnöfer
aebc90f974 s4:lsa RPC server - "dcesrv_lsa_CreateSecret" - a bit of rework
- Added 'out of memory' checks
- Added checks regarding return values
- Switch to "ldb_msg_add_string" where possible

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Dec  3 21:41:39 CET 2010 on sn-devel-104
2010-12-03 21:41:39 +01:00
Matthias Dieter Wallnöfer
025aa3f053 s4:libnet/libnet_samsync_ldb,c - move away from "samdb_msg_add_string" when possible
Also here we can move to "ldb_msg_add_string" without any impact!
2010-12-03 20:44:58 +01:00
Matthias Dieter Wallnöfer
d14e0e8ff1 s4:libnet_JoinADSDomain - move away from "samdb_msg_add_string"
These calls can be substituted by "ldb_msg_add_string" without any problems -
only the allocation contexts of the SPNs and the DNS hostnames have to adapted.
2010-12-03 20:09:31 +01:00
Matthias Dieter Wallnöfer
e2a89d6ba7 s4:auth/sam.c - when printing out a string buffer we don't strictly need the width
The precision (maximum numbers of characters) should be enough.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Dec  3 10:26:39 CET 2010 on sn-devel-104
2010-12-03 10:26:39 +01:00
Matthias Dieter Wallnöfer
4ae9aec17c s4:auth/sam.c - the check for the SAMDB needs to be on the top of the call
Otherwise it's really useless.
2010-12-03 09:19:42 +01:00
Matthias Dieter Wallnöfer
5e1c9b562c s4:auth/sam.c - fix the free of memory contexts
"tmp_ctx" needs always to be freed ("res" is freed implicitly)
2010-12-03 09:18:23 +01:00
Matthias Dieter Wallnöfer
07e18e8f7c s4:auth/sam.c - specify the SID ignore case better
As per suggestion by metze.
2010-12-03 09:17:01 +01:00
Kamen Mazdrashki
03b078c567 s4-dsdb/syntax: Map remote ATTIDs for Class OID syntax
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Thu Dec  2 18:47:59 CET 2010 on sn-devel-104
2010-12-02 18:47:59 +01:00
Kamen Mazdrashki
c1fef7efc7 s4-test/repl_schema: Test class inheritance through subClassOf 2010-12-02 19:02:55 +02:00
Kamen Mazdrashki
5bc11855f6 s4-dsdb_syntax: Be a little bit more chatty when we can't an ATTID in our cache 2010-12-02 19:02:54 +02:00
Kamen Mazdrashki
1b7070039f s4-test/fsmo: Remove unused imports 2010-12-02 19:02:54 +02:00
Kamen Mazdrashki
ad1ea5e142 s4-test/delete_object: Remove unused imports 2010-12-02 19:02:53 +02:00
Kamen Mazdrashki
28f47112d7 s4-test/repl_schema: Make ERR_NO_SUCH_OBJECT visible to us
We've lost this import somehow, now it is back in :)
2010-12-02 19:02:53 +02:00
Kamen Mazdrashki
ebdbf9bd90 s4-test/repl_schema: Test classSchema and attributeSchema replication in separate tests 2010-12-02 19:02:52 +02:00
Kamen Mazdrashki
d8e56245c0 s4-dsdb/descriptor: comment typo 2010-12-02 19:02:52 +02:00
Matthias Dieter Wallnöfer
7a5e47bf4e s4:auth/sam.c-"authsam_expand_nested_groups" - don't fail if we've memberships on non-SAM objects
This can be expected (think at a membership of a "groupOfNames" group) and we
shouldn't blame about it.

This fixes a bug reported on the technical mailing list.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Dec  2 17:17:56 CET 2010 on sn-devel-104
2010-12-02 17:17:55 +01:00
Matthias Dieter Wallnöfer
6f42da795e s4:dsdb/samdb/cracknames.c - fix various KRB5 memory leaks
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Dec  2 12:35:03 CET 2010 on sn-devel-104
2010-12-02 12:35:03 +01:00
Matthias Dieter Wallnöfer
573389c8cc s4:password_hash LDB module - allow empty ("") passwords
This seems to have been broken some time ago - till someone on the
mailing list noticed it.

I've also added a testsuite (and some additional SamDB python helpers) which
should prove this.
2010-12-02 11:51:06 +01:00
Björn Jacke
f62972b761 s4/scripting/ktpass: make shell code portable and eliminate another bash requirement
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Thu Dec  2 11:20:42 CET 2010 on sn-devel-104
2010-12-02 11:20:42 +01:00
Björn Jacke
a42c731a4b s4/ldb: fix shell syntax error in test script 2010-12-02 10:36:06 +01:00
Andrew Tridgell
f5c5fd9e82 s4-ldap: removed an incorrect talloc_move()
the parent of this session_info is either the stream_connection, or
its a system_session(). In either case reparenting it on the
ldapsrv_connection doesn't achieve anything that I can see.

The move was causing a steal on reference error because the
session_info often has multiple references.

Thanks to Metze for spotting this.

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Dec  1 22:10:42 CET 2010 on sn-devel-104
2010-12-01 22:10:42 +01:00
Matthias Dieter Wallnöfer
56290d0b33 s4:dsdb/repl/replicated_objects.c - proof if "talloc_reference" doesn't return NULL
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Dec  1 17:14:01 CET 2010 on sn-devel-104
2010-12-01 17:14:01 +01:00
Matthias Dieter Wallnöfer
8742faf19f s4:dsdb/common/util.c - "samdb_msg_add_add/delval" - introduce also here the better memory context
"msg->elements" fits better than "msg".
2010-12-01 16:30:08 +01:00
Matthias Dieter Wallnöfer
9733d71199 ldb:ldb_msg_add_value - fix here a wrong memory context
A value array allocation should belong to "msg->elements" not "msg" directly
2010-12-01 16:30:08 +01:00
Matthias Dieter Wallnöfer
0cf4569605 s4:ranged results LDB module - cosmetic - fix some indentation 2010-12-01 16:30:08 +01:00
Matthias Dieter Wallnöfer
2185f91568 s4:ranged results LDB module - "rr_search_callback" - change some memory context
"el->values" could under some circumstances be NULL (see "if" above).
2010-12-01 16:30:08 +01:00
Kamen Mazdrashki
6803a72d15 s4-test/schema: Extend the test to replicate a Class with Attribute with "mayContain" relation
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Dec  1 13:30:45 CET 2010 on sn-devel-104
2010-12-01 13:30:45 +01:00
Kamen Mazdrashki
23b4408a62 s4-dsdb/syntax: Map remote ATTIDs for Attribute OID syntax 2010-12-01 13:01:17 +02:00
Kamen Mazdrashki
29f9249bd6 s4-dsdb/syntax: Implement Remote-ATTID to Local-ATTID mapping function 2010-12-01 13:01:17 +02:00
Kamen Mazdrashki
cf8ffc37b4 s4-dreplsrv: Use working_schema when replicating from Schema NC
Schema is changed and it is quite possible we won't be able
to decode replicated objects using current Schema cache we have.

Thus, when replicating Schema, we will make a temporary Schema
cache, working_schema, so that we can fully decode objects
we recieve.
2010-12-01 13:01:17 +02:00
Kamen Mazdrashki
a42e267105 s4-dsdb/schema: Implement multi-pass working schema creation function
It is heavily based on implementation in libnet_vampire_cb_apply_schema()
function, except that it actually creates a new copy of the supplied
initial_schema + resolving all incoming objects and add them to
supplied initial_schema.

We are going to need this 'working_schema' later so we are able
to fully resolve all objects we receive on wire during DRS replication.

Working schema created is to be used only as an index to search in.
It is not supposed to be set to an ldb_context as it doesn't
contain all information for classSchema and attributeSchema objects.
2010-12-01 13:01:17 +02:00
Kamen Mazdrashki
fcc26c5d59 s4-dsdb/schema: Add Schema shallow copy function 2010-12-01 13:01:16 +02:00
Kamen Mazdrashki
16bd9dd7ae s4-dsdb/prefixMap: Add prefixMap shallow copy function 2010-12-01 13:01:16 +02:00
Kamen Mazdrashki
4041791d01 s4-repl: Let dsdb_replicated_objects_convert() to accept schema from caller
This allows us to use schema that is different than the one
set to 'ldb' to decode objects.
2010-12-01 13:01:16 +02:00
Kamen Mazdrashki
4cd16dde14 s4-ranged_result.c: Fix memory context for ranged attributes handling
Pair-Programmed-With: Zahari Zahariev <zahari.zahariev@postpath.com>

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Dec  1 11:45:48 CET 2010 on sn-devel-104
2010-12-01 11:45:48 +01:00
Andrew Tridgell
b7172e7a71 s4-drs: cope with invalid NTDS DNs from DsReplicaInfo()
w2k3 sometimes returns a deleted DN

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Dec  1 07:48:19 CET 2010 on sn-devel-104
2010-12-01 07:48:18 +01:00
Andrew Bartlett
c5bea98ddb s4:heimdal: import lorikeet-heimdal-201012010201 (commit 81fe27bcc0148d410ca4617f8759b9df1a5e935c) 2010-12-01 17:00:47 +11:00
Andrew Bartlett
c1fa6be925 s4-samba-tool Show when we have created the user successfully 2010-12-01 16:09:58 +11:00
Andrew Tridgell
c2fb350218 s4-drs: the options attribute is optional on NTDSDSA objects 2010-12-01 16:09:58 +11:00
Andrew Tridgell
a940d5d344 s4-provision: remove the disabled bit in the dns-$HOSTNAME account 2010-12-01 16:09:57 +11:00
Jelmer Vernooij
8428311ce5 pygensec: Fix initialization.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Dec  1 02:33:06 CET 2010 on sn-devel-104
2010-12-01 02:33:06 +01:00
Jelmer Vernooij
a9fb47b5d6 pyparam: Use talloc.Object. 2010-12-01 01:48:25 +01:00
Jelmer Vernooij
1f0cc6f081 pyregistry: Use talloc.Object. 2010-12-01 01:48:25 +01:00
Jelmer Vernooij
f43ffed781 pyauth: Use talloc.Object. 2010-12-01 01:48:25 +01:00
Jelmer Vernooij
fce73d7eff pygensec: Use talloc.Object. 2010-12-01 01:48:25 +01:00
Jelmer Vernooij
00251d9e56 pycredentials: Use talloc.Object. 2010-12-01 01:48:25 +01:00
Andrew Tridgell
557401b68d s4-build: added a 'make help' target 2010-12-01 11:03:25 +11:00
Andrew Tridgell
062378c1b4 s4-provision: fixed check for missing msDS-SupportedEncryptionTypes
thanks to Jelmer for spotting this
2010-12-01 11:03:25 +11:00
Andrew Tridgell
47e8cbe3d6 heimdal: fix for w2000 from lha
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Dec  1 00:59:59 CET 2010 on sn-devel-104
2010-12-01 00:59:59 +01:00
Andrew Tridgell
1286f53455 s4-dns: catch all DNS exceptions in samba_dnsupdate 2010-12-01 00:14:40 +01:00
Andrew Bartlett
29c4f3fa61 s4-smb_server Return why the ntvfs_connect() failed.
Andrew Bartlett
2010-12-01 00:14:40 +01:00
Andrew Bartlett
4ea840c3a5 s4-librpc Handle all types of GUID in the GUID() initialiser
By taking a length-limited string, we can parse binary and string GUID
values, which is particularly useful when reading from ldb.

Andrew Bartlett
2010-12-01 00:14:40 +01:00
Matthias Dieter Wallnöfer
10d1cd7af7 s4:torture - partially revert "s4:torture - prefer the termination "return"s at the end of two unittests"
This partially reverts commit 54a5c398aa.
As tridge pointed out I've overseen the nested loop in "run_iometer".
Therefore we end in a infinite loop. Obviously it wasn't run by "make
test" since then I would have detected it.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Nov 30 09:23:00 CET 2010 on sn-devel-104
2010-11-30 09:23:00 +01:00
Jelmer Vernooij
05cb5ad87c samdb: Build as public library. 2010-11-29 23:48:04 +01:00
Matthias Dieter Wallnöfer
54a5c398aa s4:torture - prefer the termination "return"s at the end of two unittests
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Nov 29 23:29:23 CET 2010 on sn-devel-104
2010-11-29 23:29:23 +01:00
Günther Deschner
53712fbb4f s4-smbtorture: only run the cupsaddsmb adobe driver test against s3.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Nov 29 18:47:17 CET 2010 on sn-devel-104
2010-11-29 18:47:17 +01:00
Günther Deschner
e722c66b98 s4-smbtorture: add torture test for cupsaddsmb win9x driver install behavior.
Guenther
2010-11-29 17:50:05 +01:00
Günther Deschner
7f2afe25e7 s4-smbtorture: make add-printerdriver test more robust against empty configfiles.
Guenther
2010-11-29 17:48:42 +01:00
Günther Deschner
118a79719c s4-smbtorture: make driver upload/removal more robust against empty filenames.
Guenther
2010-11-29 17:07:02 +01:00
Günther Deschner
b9a59ba80d s4-smbtorture: add test for Adobe PostScript driver (Win9x) installation.
Guenther
2010-11-29 15:35:19 +01:00
Günther Deschner
90a0a7e81b s4-smbtorture: handle driverfile overlap during removal in RPC-SPOOLSS-DRIVER.
Guenther
2010-11-29 15:35:19 +01:00
Günther Deschner
93582c3d29 s4-smbtorture: re-arrange RPC-SPOOLSS-DRIVER test a bit.
Guenther
2010-11-29 15:35:19 +01:00
Matthias Dieter Wallnöfer
e9c40efdcf s4:wrepl_server - add a cast on "iov_base"
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Nov 29 15:34:32 CET 2010 on sn-devel-104
2010-11-29 15:34:32 +01:00
Matthias Dieter Wallnöfer
6ce63655ef s4:lib/tls/tls_tstream.c - quiet warning on Solaris "cc" by casts 2010-11-29 14:48:13 +01:00
Matthias Dieter Wallnöfer
bd4006fb9e s4:auth/gensec/gensec_tstream.c - quiet warnings on Solaris "cc" 2010-11-29 14:48:13 +01:00
Matthias Dieter Wallnöfer
205c1e0106 s4:wrepl_server - remove unreachable statement 2010-11-29 14:48:13 +01:00
Matthias Dieter Wallnöfer
40db0b8386 s4:dcesrv_drsuapi RPC server - remove unreachable statement 2010-11-29 14:48:13 +01:00
Matthias Dieter Wallnöfer
821c962d2a s4:dns_server/dns_update.c - remove unreachable statements 2010-11-29 14:48:13 +01:00
Matthias Dieter Wallnöfer
87b887f48f s4:torture - remove unreachable statements to quiet warnings of Solaris "cc" 2010-11-29 14:48:12 +01:00
Matthias Dieter Wallnöfer
7fb9087e64 s4:auth/ntlmssp/ntlmssp_server.c - remove unnecessary ";" 2010-11-29 14:48:12 +01:00
Matthias Dieter Wallnöfer
c4625a84de heimdal:base/heimbase.c - remove an unused variable 2010-11-29 14:14:02 +01:00
Matthias Dieter Wallnöfer
0852b0f653 s4:param/pyparam_util.c - remove unused include
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Nov 29 12:56:12 CET 2010 on sn-devel-104
2010-11-29 12:56:12 +01:00
Matthias Dieter Wallnöfer
cc553eaf97 s4:auth/gensec/gensec_gssapi.c - always print error messages on the same talloc context 2010-11-29 11:33:04 +01:00
Andrew Tridgell
dc0c89cf40 s4-samdb: give a better exception if multiple users match in password change 2010-11-29 18:04:42 +11:00
Andrew Tridgell
c522cd73ac s4-repl_schema: fixed ldb exception handling 2010-11-29 18:04:42 +11:00
Andrew Tridgell
37bfc4ec38 s4-samba-tool: fixed exception handling in subcommands
this switches to the new pattern of:

 except Exception, e:
 	raise CommandError("some error message", e)
2010-11-29 18:04:42 +11:00
Andrew Tridgell
6250690310 s4-samba-tool: fixed ldb exception handling in domainlevel command
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-29 18:04:42 +11:00
Andrew Tridgell
a1f96923e6 s4-samba-tool: improved exception handling in samba-tool
we now do reasonable printing on a wide range of common exception
classes, and always force a backtrace on an exception if the debug
level is >= 3

Pair-Programmed-With: Jelmer Vernooij <jelmer@samba.org>
2010-11-29 18:04:42 +11:00
Andrew Tridgell
8c59bbd757 s4-join: fixed exception handling in join command 2010-11-29 18:04:42 +11:00
Andrew Tridgell
abe9ac53f0 s4-ldapcmp: make ldapcmp a samba-tool command
The ldapcmp tool is very useful, and should be available to Samba
admins, not just developers. This makes it a samba-tool command, which
also gives it the nicer command line handling that samba-tool has
2010-11-29 18:04:42 +11:00
Andrew Tridgell
f8d73e466b s4-ldapcmp: fixed exception handling
This pattern, which is common in our code, is wrong:
            except LdbError, (ERR_NO_SUCH_OBJECT, _):

what it actually does it to change the value of ldb.ERR_NO_SUCH_OBJECT
to be equal to whatever ldb error occurred! This led to some really
bizarre behavior
2010-11-29 18:04:42 +11:00
Andrew Tridgell
0dd2152b01 s4-pyglue: added get_debug_level() method
Pair-Programmed-With: Jelmer Vernooij <jelmer@samba.org>
2010-11-29 18:04:42 +11:00
Andrew Tridgell
33d178767b s4-loadparm: use loadparm_init_global() instead of loadparm_init()
this prevents us having two lp_ctx contexts in these tools which leads
to bizarre behaviour

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-29 18:04:42 +11:00
Andrew Tridgell
b20ce4392e s4-loadparm: added loadparm_init_global()
This ensures we use the same loadparm_context in all our command line
tools.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-11-29 18:04:42 +11:00
Andrew Tridgell
6982a00ded s4-gpo: started on samba-tool gpo list command 2010-11-29 18:04:42 +11:00
Andrew Tridgell
6cd01c9665 s4-dsdb: give full error message for operational failures 2010-11-29 18:04:42 +11:00
Andrew Tridgell
74d373d0f7 s4-pydsdb: two more GPO related flags 2010-11-29 18:04:41 +11:00
Andrew Tridgell
7a826d02a3 s4-samba-tool: started on gpo subcommands in python
this adds the listall GPO command. Currently the python variants are
available as "samba-tool gpo2 SUBCOMMAND". These will replace the
"samba-tool gpo" commands when complete
2010-11-29 18:04:41 +11:00
Andrew Tridgell
e54c8bef8a s4-pydsdb: added GPO policy flags 2010-11-29 18:04:41 +11:00
Jelmer Vernooij
97f0d6c278 samba.tests.hostconfig: Fix import.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Nov 28 18:08:33 CET 2010 on sn-devel-104
2010-11-28 18:08:33 +01:00
Jelmer Vernooij
eb5a8e29cf s4-python: Some reformatting for the purpose of pydoctor. 2010-11-28 17:23:28 +01:00
Jelmer Vernooij
20516df275 samba.upgradehelpers: Simplify code a bit. 2010-11-28 17:23:27 +01:00
Jelmer Vernooij
ca495e67b2 samba.hostconfig: Move samba.shares into samba.hostconfig. 2010-11-28 17:23:27 +01:00
Jelmer Vernooij
979d298b0d samba.getopt: Fix missing import of sys. 2010-11-28 17:23:27 +01:00
Jelmer Vernooij
28b509579d chgtdcpass: Fix program name in usage message. 2010-11-28 17:23:27 +01:00
Matthias Dieter Wallnöfer
56969adb3d s4:torture/smb2/acls.c - remove two unused variables
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Nov 28 17:22:54 CET 2010 on sn-devel-104
2010-11-28 17:22:54 +01:00
Matthias Dieter Wallnöfer
96c1cd762d s4:introduce casts before outputs of "time_t" variables
Otherwise we are getting warnings on "NetBSD".
2010-11-28 16:38:16 +01:00
Matthias Dieter Wallnöfer
ce55d7c9f0 Revert "s4:netcmd/drs.py - use "objectClass" for discovering the server and it's NTDS settings object"
This reverts commit b87c3703cf.
Andrew Bartlett told me that exactly the opposite is true - the "objectCategory"
lookup is performing better.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Nov 28 14:18:41 CET 2010 on sn-devel-104
2010-11-28 14:18:40 +01:00
Matthias Dieter Wallnöfer
736d36a948 s4:dsdb/repl/drepl* - move "lib/messaging/irpc.h" include into "drepl_service.h"
This is needed to fix a Tru64 "cc" warning regarding "enum drepl_role_master".

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Nov 28 12:46:19 CET 2010 on sn-devel-104
2010-11-28 12:46:19 +01:00
Jelmer Vernooij
4cf85a7193 s4-selftest: Ignore broken pipe error from grep.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Nov 28 05:45:05 CET 2010 on sn-devel-104
2010-11-28 05:45:05 +01:00
Jelmer Vernooij
7c65ab12af samba.provision: Fix setup_path. 2010-11-28 05:00:06 +01:00
Jelmer Vernooij
8caac9462a samba.provision: Add package with provision and backend modules. 2010-11-28 05:00:06 +01:00
Jelmer Vernooij
a7675bd501 s4-python: Fix formatting of docstrings for the purpose of pydoctor. 2010-11-28 05:00:06 +01:00
Jelmer Vernooij
6fea636888 Makefile: Add rule for pydoctor. 2010-11-28 05:00:05 +01:00
Jelmer Vernooij
ae48c626c8 samba.tests: Fix formatting. 2010-11-28 05:00:05 +01:00
Kamen Mazdrashki
092e923e2b s4-tests/bind.py: Use samba.tests.connect_samdb() instead of directly using SamDB class
connect_samdb() functino will correctly handle things like:
- session_info param - it will create system_session() using supplied
  LoadParm parameter and thus avoiding creation of multiple LoadParm
  instances (LoadParm() will mask certain command line supplied options)
- host url will be prefixed with ldap:// automatically

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Sun Nov 28 03:00:41 CET 2010 on sn-devel-104
2010-11-28 03:00:41 +01:00
Andrew Tridgell
60bf020394 s4-samba-tool: support help, and show description of commands
when you don't specify a subcommand, show the description of the
subcommands in the list of available subcommands. Also show the list
of subcommands when you use 'help', '--help' or '-h' as a subcommand

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Sun Nov 28 01:56:46 CET 2010 on sn-devel-104
2010-11-28 01:56:46 +01:00
Andrew Tridgell
2a4c6da783 s4-drs: fixed credit for C version 2010-11-28 01:11:06 +01:00
Matthias Dieter Wallnöfer
b87c3703cf s4:netcmd/drs.py - use "objectClass" for discovering the server and it's NTDS settings object
Small optimisation: we don't need to look for "nTDSDSARO" since it's a subclass
of "ntDSDSA".

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Nov 27 23:35:13 CET 2010 on sn-devel-104
2010-11-27 23:35:13 +01:00
Matthias Dieter Wallnöfer
eaac277381 s4:dsdb/repl/drepl_service.c - return the correct WERR result 2010-11-27 21:50:42 +01:00
Matthias Dieter Wallnöfer
bfb28243d0 s4:drepl_service.c - fix error macro (use "_werr" and not "werr")
Detected by Tru64 "cc".
2010-11-27 21:50:42 +01:00
Matthias Dieter Wallnöfer
a13bd32fa9 s4:dsdb/repl/drepl_out_helpers.c - print out the correct error message (werr)
Also detected by Tru64 "cc".
2010-11-27 21:50:42 +01:00
Matthias Dieter Wallnöfer
450b26b9b5 s4:lib/registry/rpc.c - remove a duplicate assignment 2010-11-27 21:50:42 +01:00