1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-05 20:58:40 +03:00

225 Commits

Author SHA1 Message Date
Jelmer Vernooij
fff18e0cc3 ldb: Rename two exported functions so they match abi_match. 2010-12-18 00:47:06 +01:00
Matthias Dieter Wallnöfer
8585de8881 ldb:rdn_name LDB module - add more RDN name constraints
And some small cleanups

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Nov 20 00:06:35 CET 2010 on sn-devel-104
2010-11-20 00:06:35 +01:00
Matthias Dieter Wallnöfer
56512fb1da ldb:skel.c - don't introduce trailing whitespaces by a module template
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 18 12:08:30 UTC 2010 on sn-devel-104
2010-11-18 12:08:30 +00:00
Matthias Dieter Wallnöfer
feb00fe7cc s4:dsdb - proof against empty RDN values where expected
This should prevent crashes as pointed out on the mailing list.
2010-11-11 10:03:40 +01:00
Andrew Tridgell
7e23363455 s4-ldb: removed ldb_includes.h
it causes problems with the openchange build as it is not installed

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov  1 21:49:47 UTC 2010 on sn-devel-104
2010-11-01 21:49:47 +00:00
Andrew Tridgell
a386ca8559 s4-ldb: enable ldb module version checking 2010-11-01 13:05:04 +00:00
Andrew Tridgell
e59a8a563b s4-ldb: fixed build of paged searches
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov  1 09:41:27 UTC 2010 on sn-devel-104
2010-11-01 09:41:27 +00:00
Andrew Tridgell
be8e91d9ca s4-ldb: convert the rest of the ldb modules to the new style 2010-11-01 18:55:19 +11:00
Andrew Bartlett
034832ccd5 s4-ldb Add LDB_REQ_SET_LOCATION to help track handler use
This greatly assists in debugging what is going on with the
ldb handle, as it indicates where it was created.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Oct 18 11:54:46 UTC 2010 on sn-devel-104
2010-10-18 11:54:46 +00:00
Andrew Tridgell
3d75111fd6 s4-ldb: added an optional operator_fn in the schema syntax
this function takes the operator being invoked, which will allow
schema functions to provide more fine grained control over
comparisons.

The key bug this was introduced to fix is the incorrect handling of
the LDB_OP_PRESENT test for deleted linked attributes. The backends
are unaware of the deleted state of these links, so they cannot do a
LDB_OP_PRESENT test on their own.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-10-13 11:00:04 +00:00
Matthias Dieter Wallnöfer
a75d271373 s4:rdn_name LDB module - move the "distinguishedName" write prevent check here
In my eyes it fits better here than in the TDB backend code.
2010-06-07 20:31:22 +02:00
Matthias Dieter Wallnöfer
dd64b253fc s4:rdn_name LDB module - use "ldb_msg_remove_attr" for deleting attributes 2010-06-06 20:48:04 +02:00
Matthias Dieter Wallnöfer
430491b2df s4:rdn_name LDB module - remove "rdn_name_find_attribute"
It does exactly the same as "ldb_msg_find_element".
2010-06-06 20:47:41 +02:00
Matthias Dieter Wallnöfer
ee524d3182 s4:"rdn_name" LDB module - fix the creation of the RDN attribute (try to normalise it)
And return always the correct error codes on the failed add operations (should
anyway be ERR_OPERATIONS_ERROR - therefore no behaviour change).
2010-05-24 14:01:06 +02:00
Anatoliy Atanasov
bcdaa23798 s4/rodc: Fix the callbacks up the stack to handle referrals on modify requests 2010-05-04 18:31:47 +02:00
Matthias Dieter Wallnöfer
8d3b7d418e LDB:asq module - change counters to "unsigned" where appropriate 2010-03-08 18:53:24 +01:00
Matthias Dieter Wallnöfer
df17e1b962 LDB:sort module - change counters to "unsigned" where appropriate 2010-03-08 18:51:27 +01:00
Matthias Dieter Wallnöfer
8248069c91 LDB:rdn name module - change counters to "unsigned" where appropriate 2010-03-08 18:51:26 +01:00
Matthias Dieter Wallnöfer
681c88798a LDB:paged searches module - change counters to "unsigned" where appropriate 2010-03-08 18:51:25 +01:00
Matthias Dieter Wallnöfer
7e7d9a8a48 LDB:paged results module - change counters to "unsigned" where appropriate 2010-03-08 18:51:25 +01:00
Brad Hards
1683d090cc LDB related spelling fixes.
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-02-22 21:45:36 +01:00
Andrew Tridgell
3ae75a4248 s4: use LDB_TYPESAFE_QSORT() instead of ldb_qsort() 2010-02-13 22:36:12 +11:00
Andrew Tridgell
8331b4c4f8 s4-ldb: check for -ve value for page size
This comes from a tip from Howard Chu. Apparently some clients
will send a -ve page size value.
2009-11-30 18:15:31 +11:00
Andrew Bartlett
f1f1bdada6 s4:ldb Remove debug traces duplicated by the new generic trace code 2009-11-02 16:36:51 +11:00
Matthias Dieter Wallnöfer
d120e7ebde s4:ldb_sort - Add some more "const"
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-10-22 10:02:43 +11:00
Matthias Dieter Wallnöfer
8536e1b947 s4:various LDB modules - "build_request" functions - propagate result codes back
It's very useful to know the exact result code when something fails and not
only a generic (by the module) created one.
Sure, there are some exception cases with specific results (special message
constellations, attributes, values...) which shouldn't be changed at all
(examples of them are in the "ldap.py" test). Therefore I looked very
carefully to not change them.
2009-10-06 19:41:16 +02:00
Matthias Dieter Wallnöfer
deb268f7fa s4:rdn_name - fix up the rename operation
A function call was wrong ("ldb_request" rathen than "ldb_next_request").
2009-10-03 10:36:41 +02:00
Matthias Dieter Wallnöfer
2b9b232912 Revert "s4:LDB/LDAP - Re-allow renames"
This reverts commit 767fce6fccf484b547219abd5e6abc941eacaf92.

Simo pointed out that the patch generates race conditions. We need to solve this
using a new control.
2009-10-03 00:14:05 +02:00
Matthias Dieter Wallnöfer
767fce6fcc s4:LDB/LDAP - Re-allow renames
The main problem is that the "rdn_name" module launches on a rename request also
a modification one with the "special attributes" which can't be changed directly.
An introduced flag helps to bypass the restriction.
2009-10-02 21:27:46 +02:00
Andrew Bartlett
2651603269 s4:ldb Don't allow RDN to be modified with an LDB modify message
Found by the Microsoft testsuite at the AD interop event.

Andrew Bartlett
2009-10-02 19:17:24 +02:00
Matthias Dieter Wallnöfer
d2ac4cbcee s4:rdn_name module - a normal error message should be enough for this failure
I don't think that we really want to have this error printed out on the server
console (stdout) since this hasn't serious results as DB or data corruption
and similar.
2009-10-02 19:17:23 +02:00
Matthias Dieter Wallnöfer
ae8e5b48e7 s4: Fix typo 2009-09-06 12:30:37 +02:00
Matthias Dieter Wallnöfer
b255a41dca s4:operational module - move and enhancements
This moves the "operational" LDB module to the right place under "dsdb/samdb/ldb_modules"
(suggested by abartlet) and enhances it for supporting dynamic generated
"primaryGroupToken" for AD groups. This should fix bug .
2009-08-11 12:59:15 +02:00
Andrew Bartlett
dd557cc361 s4:ldb Make error message in rnd_name more useful 2009-08-07 14:22:54 +10:00
Matthias Dieter Wallnöfer
39b0158373 s4:ldb Cosmetic corrections in "rdn_name" module 2009-08-05 20:28:05 +02:00
Sumit Bose
9d7cb4826a remove all '\n' from ldb_debug 2009-07-14 11:21:11 -04:00
Andrew Tridgell
6836b16dda fixed server side sort control
when sorting a record that does not have the requested sort attribute
then put those records last in the sort result
2009-06-10 10:33:53 +10:00
Andrew Kroeger
bf863bccb6 s4:ldb:modules: Correct typos. 2009-05-26 16:38:39 -04:00
Andrew Bartlett
4a45b0da57 s4:ldb Allow paged_searches to be mixed with other controls
I want to mix this with the server-side sort in particular.

Andrew Bartlett
2009-03-20 16:45:52 +11:00
Andrew Bartlett
1dc5b90e86 s4:ldb Fix the paged_searches module
This simplifies the code, removes presumptions about being the only
control in the reply, and allows it to function against Windows 2008.

For searches which did not require a paged result, the module was
simply returning a failure when the compleated search did not include
a paged result control.

Andrew Bartlett
2009-03-20 16:28:40 +11:00
Simo Sorce
1cd7fe7194 Fix headers, ldb_includes.h is a private header,
do not reference it from ldb.h
2009-02-23 17:38:11 -05:00
Volker Lendecke
d75fe9b393 Fix Coverity ID 872 -- we have alread dereferenced "ac" 2 lines above 2009-02-12 23:17:19 +01:00
Simo Sorce
380874ef86 Fix the mess with ldb includes.
Separate again the public from the private headers.

Add a new header specific for modules.
Also add service function for modules as now ldb_context and ldb_module are
opaque structures for them.
2009-01-30 01:02:03 -05:00
Jelmer Vernooij
479b4b09e1 Fix accidental condition inversion. 2008-12-24 05:39:29 +01:00
Jelmer Vernooij
bd64688c6a Fix more compiler warnings in various places. 2008-12-23 22:57:11 +01:00
Andrew Bartlett
596fe759e1 s4:ldb: make it possible to return per entry controls
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2008-12-17 12:29:27 +11:00
Jelmer Vernooij
87ec1d2532 Make sure prototypes are always included, make some functions static and
remove some unused functions.
2008-10-20 18:59:51 +02:00
Simo Sorce
7fb9007f3d Fix very old bug in ASQ 2008-10-14 12:25:18 -04:00
Simo Sorce
4f40ee2b86 LDB ASYNC: core modules 2008-09-29 04:22:19 +02:00
Jelmer Vernooij
b0a95ad2f6 Revert LDB return code patches from Matthias. 2008-09-25 00:01:05 +02:00