1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

368 Commits

Author SHA1 Message Date
Simo Sorce
7f833458ca r19489: Change ldb_msg_add_value and ldb_msg_add_empty to take a foruth argument.
This is a pointer to an element pointer. If it is not null it will be
filled with the pointer of the manipulated element.
Will avoid double searches on the elements list in some cases.
(This used to be commit 0fa5d4bc22)
2007-10-10 14:24:38 -05:00
Stefan Metzmacher
7c95ae3aca r19482: remove pointless cast
metze
(This used to be commit 81a975100c)
2007-10-10 14:21:41 -05:00
Rafal Szczesniak
f8a82ebe2b r19398: more comments
rafal
(This used to be commit 2ed463e3cd)
2007-10-10 14:21:25 -05:00
Andrew Bartlett
2ac52f809a r19309: Split out checks for LDB_SUCCESS from checks for the expected number
of returned entries.

Andrew Bartlett
(This used to be commit 84efd9ecd9)
2007-10-10 14:21:06 -05:00
Andrew Bartlett
379e6598e1 r19308: Merge samsync fixes from SAMBA_4_0_RELEASE
Andrew Bartlett
(This used to be commit 3310032399)
2007-10-10 14:21:06 -05:00
Simo Sorce
59b66744f7 r19299: Fix possible memleaks
(This used to be commit 6fad80bb09)
2007-10-10 14:21:04 -05:00
Andrew Bartlett
57b8c5cd22 r19266: Add a target_hostname element to the binding struct. This allows us
to perform a lookup once, resolve the name to an IP, while still
communicating the full name to the lower layers, for kerberos etc.

This fixes 'net samdump', which was failing due to the schannel target
name being *smbserver.

Andrew Bartlett
(This used to be commit 0546f487f4)
2007-10-10 14:21:00 -05:00
Andrew Bartlett
9ce0de670b r19261: Fix use of unitialised variables. (The binding string is used, if not
NULL).

This showed up in a manual pre-TP3 test of the 'net samdump' code, and
shows the critical need for the windows testing infrustructure on the
build farm.

Andrew Bartlett
(This used to be commit 9cef40779a)
2007-10-10 14:20:59 -05:00
Rafal Szczesniak
71ec249e02 r19053: match the flag values with the actual equivalents in samr.idl
rafal
(This used to be commit 07aee70811)
2007-10-10 14:20:32 -05:00
Rafal Szczesniak
89e4387a08 r19024: remove read-only and policy dependent fields and flags
from user modify routines.

rafal
(This used to be commit 7ca0d3dbcb)
2007-10-10 14:20:29 -05:00
Rafal Szczesniak
2a689f463b r18752: When change is a big one, it needs to be made in a couple
of set user info calls one after another (each one using
different info level). Also, try to do as many changes as
possible using a single infolevel.

rafal
(This used to be commit cee9a69ffa)
2007-10-10 14:19:07 -05:00
Günther Deschner
8c8240c677 r18743: Mention share name in error output.
Guenther
(This used to be commit 18505ce283)
2007-10-10 14:19:06 -05:00
Rafal Szczesniak
3394bb23fd r18682: a bit of a change in setfield function.
one more change to do...

rafal
(This used to be commit 43b550c83b)
2007-10-10 14:19:01 -05:00
Rafal Szczesniak
1ba24e8680 r18657: handle the case where rpc call went fine, but the result
not necessariy did.

rafal
(This used to be commit 69c379cc63)
2007-10-10 14:19:00 -05:00
Rafal Szczesniak
e0da0acac0 r18656: fix stupid mistake causing segfaults in torture test
and also add one more field to be set.

rafal
(This used to be commit e2621d0063)
2007-10-10 14:19:00 -05:00
Rafal Szczesniak
602b604599 r18655: add more fields and better handle the error case where fields
setting routine don't know how to do that (and user info level
is invalid).

rafal
(This used to be commit a7564931a7)
2007-10-10 14:18:59 -05:00
Rafal Szczesniak
2ccef5554f r18615: add more time fields and fix a silly mistake.
rafal
(This used to be commit 06e0c5d166)
2007-10-10 14:18:56 -05:00
Günther Deschner
57cd2235fa r18611: Do not return NT_STATUS_OK when libnet_Add|DelShare has failed.
Guenther
(This used to be commit 1709ad741b)
2007-10-10 14:18:56 -05:00
Günther Deschner
28c9c212bc r18610: Fix typo.
Guenther
(This used to be commit 759914a07e)
2007-10-10 14:18:56 -05:00
Günther Deschner
e7ede84c33 r18609: error_string should not contain newlines.
Guenther
(This used to be commit 5566667564)
2007-10-10 14:18:56 -05:00
Stefan Metzmacher
6e47a2bb75 r18607: remove unused structure element
rafal: is there a reason why we don't use libnet_AddShare() in the torture test?

metze
(This used to be commit 070a98379a)
2007-10-10 14:18:55 -05:00
Andrew Tridgell
e13715774c r18587: fixed a potential memory leak in libnet
(This used to be commit 935f6f34cf)
2007-10-10 14:18:52 -05:00
Rafal Szczesniak
0f0879eacf r18104: A couple of important fixes to samr domain open so that
the corresponding test may pass.

rafal
(This used to be commit f0eb209e84)
2007-10-10 14:17:17 -05:00
Rafal Szczesniak
1da09b94eb r18101: Use composite_create function and add monitor function pointer
to the state structure.

rafal
(This used to be commit 76d73bc97d)
2007-10-10 14:17:16 -05:00
Andrew Bartlett
626d3ad012 r17954: Avoid including \n in error strings (left over from DEBUG() conversion).
Make it easier to debug CrackNames failures.

Andrew Bartlett
(This used to be commit 5dd07074db)
2007-10-10 14:16:56 -05:00
Rafal Szczesniak
b07435f3e1 r17938: More comments.
rafal
(This used to be commit 4a127aacfa)
2007-10-10 14:16:55 -05:00
Jelmer Vernooij
0329d755a7 r17930: Merge noinclude branch:
* Move dlinklist.h, smb.h to subsystem-specific directories
 * Clean up ads.h and move what is left of it to dsdb/
   (only place where it's used)
(This used to be commit f7afa1cb77)
2007-10-10 14:16:54 -05:00
Rafal Szczesniak
1e46d3a46a r17856: The two new functions - libnet_LookupName and libnet_UserInfo.
These two perform name resolving in SAM database and fetching
user account information, respectively. The code is quite rough
yet, but it builds and basic tests work. Now, I'm working on
cleaning it up...

rafal
(This used to be commit 4a932255a0)
2007-10-10 14:16:48 -05:00
Rafal Szczesniak
1f8fda717f r17670: 1) Refactor libnet context structure a bit, to have rpc connection
properties more consistently reflected.
2) Add domain open routine for lsa pipe - this is needed for ongoing
   name resolve function.

Tests (still neglected) and comments to follow.

rafal
(This used to be commit fe5652c2b8)
2007-10-10 14:16:21 -05:00
Simo Sorce
a23b63a8e5 r17516: Change helper function names to make more clear what they are meant to do
(This used to be commit ad75cf8695)
2007-10-10 14:15:31 -05:00
Rafal Szczesniak
5104e4e83f r17472: Remove unused variable.
rafal
(This used to be commit 04c94e4a52)
2007-10-10 14:15:27 -05:00
Rafal Szczesniak
8b659a2439 r17450: A bit more protection against memory allocation errors.
rafal
(This used to be commit a3ef0d051a)
2007-10-10 14:15:26 -05:00
Rafal Szczesniak
84f8d208ef r17448: Define macros to set fields in api function modifying user account.
rafal
(This used to be commit 8d9330c490)
2007-10-10 14:15:26 -05:00
Rafal Szczesniak
9ea3b567e4 r17447: Add more fields to user modify routines.
rafal
(This used to be commit 8fa1cd62ec)
2007-10-10 14:15:26 -05:00
Rafal Szczesniak
45b64e394d r17079: Remove an attempt to connect on ncacn_ip_tcp transport after failure
on ncacn_np, as abartlet suggested. Also, named pipe remains the default
transport for all kinds of servers to be contacted.

rafal
(This used to be commit 76888c74a6)
2007-10-10 14:10:11 -05:00
Rafal Szczesniak
6078bfda5e r17028: Remove extra newline.
rafal
(This used to be commit 7da9ebffbd)
2007-10-10 14:10:09 -05:00
Rafal Szczesniak
752fda46a5 r17027: My copyright notice.
rafal
(This used to be commit a2229f8c80)
2007-10-10 14:10:09 -05:00
Rafal Szczesniak
434087bb4b r17026: Make rpc connect routine a bit smarter. Try to connect again
using different transport and possibly address type, when
the first attempt fails (only if it makes any sense, of course).
This may be especially useful when connecting DCs and PDCs in
mixed environments.

Also, add monitor messages issuing.

rafal
(This used to be commit d69b31230d)
2007-10-10 14:10:09 -05:00
Rafal Szczesniak
ad521ee793 r17001: Prepare a new monitor messages.
rafal
(This used to be commit aaa2a5a27a)
2007-10-10 14:10:07 -05:00
Rafal Szczesniak
861ec81048 r16895: Add continue function and prevent from segfaulting (or unpredictable
behaviour) if composite context returned from _send function was NULL.

rafal
(This used to be commit d9fce228d0)
2007-10-10 14:09:57 -05:00
Andrew Bartlett
12dc0ae78c r16830: Fix IBM checker and GCC warnings.
Andrew Bartlett
(This used to be commit 5ef924bc73)
2007-10-10 14:09:48 -05:00
Rafal Szczesniak
5b19070ac7 r16694: Store lsa rpc pipe pointer in a right place.
rafal
(This used to be commit fa6b52dbf7)
2007-10-10 14:09:39 -05:00
Rafal Szczesniak
833ef6b678 r16693: Name type should be passed further down the lookup engine instead
of assuming only PDC name type. Also, fix the comment.

rafal
(This used to be commit 436c8a7211)
2007-10-10 14:09:38 -05:00
Rafal Szczesniak
828e95e81f r16692: More comments and further code in set_user_changes routine.
rafal
(This used to be commit c58fa8676c)
2007-10-10 14:09:38 -05:00
Rafal Szczesniak
6e92c83d52 r16573: Fixes in comments.
rafal
(This used to be commit 1258e6cad8)
2007-10-10 14:09:36 -05:00
Rafal Szczesniak
61705d9c55 r16572: More comments and simple refactoring of one condition.
rafal
(This used to be commit 24006a3601)
2007-10-10 14:09:36 -05:00
Rafal Szczesniak
7414c0206f r16532: Tell username from account name (source from target, when
changing).

rafal
(This used to be commit e5a50ca14a)
2007-10-10 14:09:33 -05:00
Rafal Szczesniak
7d1533f616 r16531: Add a function preparing argument for modify user routine.
rafal
(This used to be commit d91cbec264)
2007-10-10 14:09:33 -05:00
Rafal Szczesniak
3ef6f35dde r16530: Send monitor messages only after successful receiving result of a stage.
rafal
(This used to be commit e5dc631163)
2007-10-10 14:09:33 -05:00
Rafal Szczesniak
240ec86942 r16476: Error in composite functions implemented the 'old way' (single event handler,
no continue functions) need to report an error by means of state only.
composite_error calls event handler function which frees the context and
state structure. This fixes a segfault in some cases (caught it on modifyuser
test).

rafal
(This used to be commit 9e800fd0cf)
2007-10-10 14:09:30 -05:00
Andrew Bartlett
345c9f043f r16226: Fixes for various segfault bugs found against a buggy Samba4. With
the current API we need to check both that the RPC didn't fault, and
that the query succeeded.

Also print the right things in debug messages.

Andrew Bartlett
(This used to be commit d18e515391)
2007-10-10 14:09:06 -05:00
Rafal Szczesniak
9fb340758b r16211: Refactor domain_opened function a bit and add a few comments.
rafal
(This used to be commit d8113fa5e1)
2007-10-10 14:09:06 -05:00
Rafal Szczesniak
04bc987b29 r15996: Implement a missing monitor message.
rafal
(This used to be commit 37ec35672e)
2007-10-10 14:08:47 -05:00
Rafal Szczesniak
f40a2e9786 r15940: Add new field to pass username to libnet_rpc_userinfo function.
rafal
(This used to be commit 16b4b4dbb7)
2007-10-10 14:08:42 -05:00
Rafal Szczesniak
95399b1e66 r15938: Extend userinfo call with one optional stage - lookup for
username to resolve it to a rid, when a sid argument is not
explicitly provided.

rafal
(This used to be commit 9bc4ef267c)
2007-10-10 14:08:42 -05:00
Rafal Szczesniak
ab7d25c4d1 r15937: Currently, we don't use nor support distinguished call levels, so remove
them until we do such thing. There's no need to complicate things more
at the moment.

rafal
(This used to be commit 94fb191e6b)
2007-10-10 14:08:42 -05:00
Rafal Szczesniak
8a6ac85a96 r15920: Move userman.c and userinfo.c definition into respective
header files instead of composite.h

rafal
(This used to be commit 8cafbe7afe)
2007-10-10 14:08:40 -05:00
Rafal Szczesniak
78fea25786 r15919: - Create function checking prerequisites like valid domain
opened and rpc pipe connected. Each user management routine
  calls the function before doing their job
- Initial work on user modify functionality (does nothing yet)

rafal
(This used to be commit 51501cdeef)
2007-10-10 14:08:40 -05:00
Stefan Metzmacher
9ff4fcab36 r15858: - initialize s->r.out
- don't check for mem_ctx, ctx and r, we should crash when they're wrong
  as it's a programmer error!
- pass the error string to the caller

metze
(This used to be commit 5f65447f5d)
2007-10-10 14:08:33 -05:00
Stefan Metzmacher
d8376686cd r15857: don't clear the error string after setting it
metze
(This used to be commit d273d8ae52)
2007-10-10 14:08:33 -05:00
Andrew Tridgell
3372344ade r15850: another spot where r->out.error_string can be uninitialied
(This used to be commit 4898b29c32)
2007-10-10 14:08:32 -05:00
Andrew Tridgell
6e0511f3ee r15849: ensure we don't try to talloc_steal() an invalid error_string in
r->out on error
(This used to be commit 1d1d2aaeae)
2007-10-10 14:08:31 -05:00
Rafal Szczesniak
dda3dceac7 r15726: Comments and a couple of minor formattings in the code.
rafal
(This used to be commit 2ab8343e99)
2007-10-10 14:08:09 -05:00
Rafal Szczesniak
3b07abf2d7 r15667: Make sure the rpc pipe pointers are zeroed during
initialisation of libnet_context.
This fixes a valgrind warning.

rafal
(This used to be commit b751eb1102)
2007-10-10 14:08:05 -05:00
Rafal Szczesniak
e1e4474fb0 r15666: Fix a silly typo.
rafal
(This used to be commit dc93aef09a)
2007-10-10 14:08:05 -05:00
Rafal Szczesniak
251ea035b5 r15663: Turn libnet_DeleteUser into async function and fix subtle bug probably
causing ejsnet test to segfault. Also, cleanup a bit and add monitor
fn pointer to internal user delete libnet function.
Time for some comments now.

rafal
(This used to be commit 89e9a88719)
2007-10-10 14:08:04 -05:00
Rafal Szczesniak
16b5eac38d r15625: Partial commit of my current work. It makes libnet api functions
a bit more smart and more aware of what libnet_context can offer.
The context is a help when some of the arguments are not passed
(programmer counts on using sensible defaults) and stores some of
results so that similar subsequent calls don't need to reopen some
of policy handles, pipes, etc. again. It also helps to hide some
of details the library user don't really want to know much about.

Also, change domain open function to be part of public api, as
it is going to be used in ejsnet interface.

Note, this is work in progress. Comments are welcome.

rafal
(This used to be commit 1ed80c594c)
2007-10-10 14:07:24 -05:00
Andrew Bartlett
7f0a396e3b r15504: Revert -r 15500 and -r 15503 until I'm awake, and can get my head
around the mess that is composite functions...

Async might be all the rage, but it's bloody painful to debug.

Andrew Bartlett
(This used to be commit 756e1dad7c)
2007-10-10 14:05:43 -05:00
Andrew Bartlett
5f36534629 r15500: Add support for interactive prompting on bad passwords to the RPC libraries.
This support requires that the bind_ack and alter_ack recv functions
also be send the DCE/RPC fault.  This would be best done by having the
ack run as a normal RPC reply callback, but this isn't easily possible
for now.

Andrew Bartlett
(This used to be commit be6dde22fe)
2007-10-10 14:05:42 -05:00
Rafal Szczesniak
4010a61fd8 r15489: Typo fixes.
rafal
(This used to be commit 221907fc0d)
2007-10-10 14:05:41 -05:00
Rafal Szczesniak
f8f231da25 r15488: This structure is not needed any longer.
rafal
(This used to be commit 45cd7bc4ec)
2007-10-10 14:05:40 -05:00
Rafal Szczesniak
4d8aaf5f1c r15487: More comments and a few minor changes (not even fixes).
rafal
(This used to be commit 12d0faf9bc)
2007-10-10 14:05:40 -05:00
Rafal Szczesniak
eff21e317e r15459: Add forgotten guid retrieval among other data and thus prevent
from returning uninitialised structure member. Thank heavens for build
farm and valgrind :)

rafal
(This used to be commit daca283990)
2007-10-10 14:05:38 -05:00
Rafal Szczesniak
ccf5696b97 r15439: Reorder the code a bit to be like in other calls. More comments
and comment-fixes.

rafal
(This used to be commit d35f1e07be)
2007-10-10 14:05:37 -05:00
Rafal Szczesniak
538adbf677 r15435: Turn libnet_RpcConnectDCInfo into another level of libnet_RpcConnect
and make it async. Also, update any other usages of old function.
Build goes fine and so do tests, comments to follow.

rafal
(This used to be commit aef0a2de9d)
2007-10-10 14:05:36 -05:00
Andrew Bartlett
5f4d86f955 r15426: Implement SPNEGO as the default RPC authentication mechanism. Where
this isn't supported, fallback to NTLM.

Also, where we get a failure as 'logon failure', try and do a '3
tries' for the password, like we already do for CIFS.  (Incomplete:
needs a mapping between RPC errors and the logon failure NTSTATUS).

Because we don't yet support Kerberos sign/seal to win2k3 SP1 for
DCE/RPC, disable this (causing SPNEGO to negotiate NTLM) when kerberos
isn't demanded.

Andrew Bartlett
(This used to be commit b3212d1fb9)
2007-10-10 14:05:36 -05:00
Jelmer Vernooij
e002300f23 r15328: Move some functions around, remove dependencies.
Remove some autogenerated headers (which had prototypes now autogenerated by pidl)
Remove ndr_security.h from a few places - it's no longer necessary
(This used to be commit c19c2b51d3)
2007-10-10 14:05:17 -05:00
Jelmer Vernooij
69b51f702a r15207: Introduce PRIVATE_DEPENDENCIES and PUBLIC_DEPENDENCIES as replacement
for REQUIRED_SUBSYSTEMS.
(This used to be commit adc8a019b6)
2007-10-10 14:04:18 -05:00
Andrew Tridgell
48bf8e2b6d r14983: fix an uninitialised var
(This used to be commit 58ac1e4eb1)
2007-10-10 14:00:51 -05:00
Stefan Metzmacher
1af925f394 r14860: create libcli/security/security.h
metze
(This used to be commit 9ec706238c)
2007-10-10 13:59:44 -05:00
Andrew Bartlett
d52f31848d r14716: Remove username from debug message, it just causes valgrind assertions.
Andrew Bartlett
(This used to be commit c978fea2a1)
2007-10-10 13:59:12 -05:00
Rafal Szczesniak
d0c7651a7d r14591: More comments.
rafal
(This used to be commit 44b89cd47a)
2007-10-10 13:58:57 -05:00
Jelmer Vernooij
184955ffd7 r14572: Give libraries saner names, remove some .pc files, make some things
subsystems in case a library doesn't make sense.
(This used to be commit ed382873fd)
2007-10-10 13:58:49 -05:00
Rafal Szczesniak
1d23d26dd2 r14568: Remove unused function.
rafal
(This used to be commit 473d6c8e68)
2007-10-10 13:58:48 -05:00
Rafal Szczesniak
79f844e6a6 r14566: Remove unnecessary headers.
rafal
(This used to be commit 1ba4245fcb)
2007-10-10 13:58:48 -05:00
Rafal Szczesniak
986532fbbd r14560: Finally! Start working on async libnet_RpcConnect and other
rpc-related calls.

rafal
(This used to be commit 860f9bcb1e)
2007-10-10 13:58:46 -05:00
Jelmer Vernooij
35349a58df r14542: Remove librpc, libndr and libnbt from includes.h
(This used to be commit 51b4270513)
2007-10-10 13:58:42 -05:00
Jelmer Vernooij
b785a7c40c r14492: Fix shared libs - set SO_VERSION to 0 everywhere for now.
(This used to be commit 4682bc5ce0)
2007-10-10 13:57:32 -05:00
Jelmer Vernooij
4f1c8daa36 r14470: Remove some unnecessary headers.
(This used to be commit f7312dab3b)
2007-10-10 13:57:29 -05:00
Jelmer Vernooij
8528016978 r14464: Don't include ndr_BASENAME.h files unless strictly required, instead
try to include just the BASENAME.h files (containing only structs)
(This used to be commit 3dd477ca51)
2007-10-10 13:57:27 -05:00
Jelmer Vernooij
1060f6b3f6 r14402: Generate seperate headers for RPC client functions.
(This used to be commit 7054ebf024)
2007-10-10 13:57:19 -05:00
Jelmer Vernooij
7651d097b4 r14383: Fix non-developer build.
(This used to be commit f4de155c94)
2007-10-10 13:57:17 -05:00
Jelmer Vernooij
e3f2414cf9 r14380: Reduce the size of structs.h
(This used to be commit 1a16a6f1df)
2007-10-10 13:57:16 -05:00
Jelmer Vernooij
3f16241a1d r14363: Remove credentials.h from the global includes.
(This used to be commit 98c4c30513)
2007-10-10 13:57:14 -05:00
Jelmer Vernooij
e153a8099e r14327: Replace MAJOR_VERSION/MINOR_VERSION/RELEASE_VERSION with two parameters:
- VERSION: should contain the current version. Will be made part of the filename.
 - SO_VERSION: should contain the latest version that this on is compatible to. Will be used for setting the soname of the shared library.

Fix sonames and use them on platforms that support them
Remove symlinking code. ldconfig will take care of creating the symlinks now
that we set the soname.
(This used to be commit 7871b07e21)
2007-10-10 13:57:12 -05:00
Stefan Metzmacher
da7c2d3a66 r14063: libnet depends on dcerpc
metze
(This used to be commit 7fc2d08269)
2007-10-10 13:52:39 -05:00
Andrew Bartlett
91b1815fa9 r14058: Try to make the continuation on the list of password set mechs clearer.
Andrew Bartlett
(This used to be commit 0aa7160a66)
2007-10-10 13:52:38 -05:00
Jelmer Vernooij
17ae598141 r13938: Around round of splitups
(This used to be commit 2d655f0528)
2007-10-10 13:52:29 -05:00
Jelmer Vernooij
4ac2be9958 r13924: Split more prototypes out of include/proto.h + initial work on header
file dependencies
(This used to be commit 1228358767)
2007-10-10 13:52:24 -05:00
Jelmer Vernooij
ba564a901e r13903: Don't generate prototypes for modules and binaries in include/proto.h by
default.
(This used to be commit c80a8f1102)
2007-10-10 13:52:21 -05:00