sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Code
19,463 Commits 60 Branches 1,145 Tags 452 MiB
0498f3b889
Commit Graph

19463 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Allison
b5c2c5cd25 r14357: Try and fix Coverity #169 by making the pointer 
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
 line, and those below, will be ignored--

M    source/smbd/posix_acls.c
(This used to be commit b8397c9f33)
 2007-10-10 11:15:26 -05:00
Jeremy Allison
846c4520ce r14355: Try and fix Coverity #158 by making the pointer 
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit 7ada96a1cf)
 2007-10-10 11:15:26 -05:00
Jeremy Allison
d1684fa82e r14353: Fix coverity bugs #61 and #62. Remember to divide by 
the size of the data table. Clean up the struct a little.
Jeremy.
(This used to be commit 338538410d)
 2007-10-10 11:15:26 -05:00
Jeremy Allison
8f96b1bf0f r14351: Ensure we use the minimum of PATH_MAX and sizeof(pstring). 
Fix Coverity #59.
Jeremy.
(This used to be commit d793e1550c)
 2007-10-10 11:15:26 -05:00
Jeremy Allison
f6071a90c7 r14345: Fix Coverity #71. We don't currently propagate *any* 
alloc error back up the stack from smbldap_set_mod()
so ensure we abort correctly.
Jeremy.
(This used to be commit 9a1e35079a)
 2007-10-10 11:15:26 -05:00
Jeremy Allison
ca9be7c92b r14342: Fix coverity #68, resource leak on error path. 
Jeremy.
(This used to be commit 7520a8d2a1)
 2007-10-10 11:15:26 -05:00
Jeremy Allison
abafc0d887 r14340: Fix coverity #78, resource leak in error path. 
Jeremy.
(This used to be commit 76c4f2c4dc)
 2007-10-10 11:15:26 -05:00
Jeremy Allison
bd1e853c19 r14338: Fix coverity #55 by explicit cast. 
Jeremy.
(This used to be commit 1fece52da4)
 2007-10-10 11:15:25 -05:00
Jeremy Allison
ed5095a490 r14336: Try and quieten coverity #53 and #54. Make it obvious 
we're using -1 as a special size_t case by casting.
Jeremy.
(This used to be commit 415530bd08)
 2007-10-10 11:15:25 -05:00
Jeremy Allison
53019f5a16 r14333: Fix coverity #77, ensure we can't exit after allocation. 
Jeremy.
(This used to be commit 15d78ab1fc)
 2007-10-10 11:15:25 -05:00
Lars Müller
cc41fa4ad7 r14331: Add a comment on top of test_pam_modules about what we're testing. 
(This used to be commit 90eb092083)
 2007-10-10 11:15:25 -05:00
Günther Deschner
0be0bc1151 r14329: Fix the build on systems without libcom_err. 
Guenther
(This used to be commit 44fcd3113b)
 2007-10-10 11:15:25 -05:00
Lars Müller
fe9ddcace9 r14326: First catch of make test_pam_modules. 
Testing pam_smbpass pam_winbind
dlopen() of "./bin/pam_smbpass.so" succeeded.
dlopen() of "./bin/pam_winbind.so" failed: ././bin/pam_winbind.so:
undefined symbol: secrets_fetch_domain_sid
make: *** [test_pam_modules] Error 1
(This used to be commit 4b545e0ce6)
 2007-10-10 11:15:25 -05:00
Lars Müller
9b27791644 r14325: Add pam_modules rule which builds the configure(d) pam modules. This is 
called as part of the all rule (again only if pam modules are requested
by configure).

Add pam_winbind rule.

Ensure proto_exists before we build the pam modules.

Add test_pam_modules rule to test if the built pam modules have any
unresolved symbols.  For test_pam_modules we use script/tests/dlopen.sh
which was written by Nalin Dahyabhai <nalin@redhat.com>.  Thanks Nalin!
RedHat and SuSE use this script to test nss and pam modules since
several years.
(This used to be commit 71b2eb55ad)
 2007-10-10 11:15:25 -05:00
Günther Deschner
b97a69dce3 r14321: When we have libnscd and winbindd comes (back) online, try to flush the 
nscd caches so that NSS-calls can deliver accurate information.

Guenther
(This used to be commit a32a423a0e)
 2007-10-10 11:15:24 -05:00
Lars Müller
b372fd2cff r14317: Use source/bin as dir to link pam_winbind instead of source/nsswitch/ 
The intention is to have the resulting binaries at one place.  This is
also usefull for upcoming changes to provide a test_pammodules rule.

With these changes I even got aware of
testsuite/nsswitch/pam_winbind_syms.exp  But this only covers
pam_winbind.
(This used to be commit 9883957b74)
 2007-10-10 11:15:24 -05:00
Jeremy Allison
d72bb5627c r14303: Fix coverity #223. In a loop we were forgetting to free 
resources on error exit path.
Jeremy.
(This used to be commit f71aa3ab8f)
 2007-10-10 11:15:24 -05:00
Jeremy Allison
ad838bf65e r14301: Fix coverity #224. In a loop we were forgetting to free 
resources on error exit path.
Jeremy.
(This used to be commit f1a5e5aefe)
 2007-10-10 11:15:24 -05:00
Jeremy Allison
860015db1f r14299: Fix coverity #225. In a loop we were forgetting to free 
resources on error exit path.
Jeremy.
(This used to be commit 1c0b4ed0ac)
 2007-10-10 11:15:24 -05:00
Volker Lendecke
659eb9b71f r14298: The other half of Coverity # 217 
(This used to be commit b9fb3fc0e3)
 2007-10-10 11:15:24 -05:00
Jeremy Allison
432490a4b8 r14292: Janitor for tridge (samba3 talloc is almost identical 
to Samba4 talloc).
Jeremy

 - make the snprintf call in talloc portable to older solaris boxes

 - fixed an error found sing the beam analyser
(This used to be commit 1e1bae7afd)
 2007-10-10 11:15:23 -05:00
Jeremy Allison
19879eba83 r14289: Fix coverity #101, resource leak on error code path. 
Jeremy.
(This used to be commit d9e1d6fed0)
 2007-10-10 11:15:23 -05:00
Jeremy Allison
acc651a31b r14286: Similar clarifiction fix for coverity #102. 
Jeremy.
(This used to be commit f458596b0e)
 2007-10-10 11:15:23 -05:00
Jeremy Allison
e4600491cf r14284: Fix coverity bug #103. Make code clearer - probably 
not a real issue but this code is easier to read.
Jeremy.
(This used to be commit 6621acc68f)
 2007-10-10 11:15:23 -05:00
Jeremy Allison
75247c5ea2 r14282: Change centry_string to only use talloc. Should 
quieten coverity bug #194 (which I think is a
false positive).
Jeremy.
(This used to be commit 07d8b02d3d)
 2007-10-10 11:15:23 -05:00
Jim McDonough
2167ec9dd5 r14280: Fix Coverity #129 and 130: check before dereferencing a pointer. This 
was especially silly as we checked immediately _after_ dereferencing it
:-/
(This used to be commit 7ebfe2cb26)
 2007-10-10 11:15:23 -05:00
Jim McDonough
025041eba4 r14279: Fix coverity #86, 87, 88, 89: 
Free grp_sid and owner_sid before returning.  Also, only allow one group
or owner.
(This used to be commit 1043e0d90c)
 2007-10-10 11:15:23 -05:00
Jim McDonough
e0793b1b28 r14278: Remainder of fix for Coverity #79,80,81: only allow GROUP or OWNER to be 
specified once in an ACL, so it can be allocated a second time,
overwriting the first
(This used to be commit 1804a8a01e)
 2007-10-10 11:15:22 -05:00
Jeremy Allison
478cd9dd53 r14275: Shut-up coverity false positive (bug #199) by making an assertion 
explicit.
Jeremy.
(This used to be commit aeae20a8d9)
 2007-10-10 11:15:22 -05:00
Jeremy Allison
3b58c82a52 r14273: Fix coverity bug #202. Memory leak on error path. 
Jeremy.
(This used to be commit d2be8163f2)
 2007-10-10 11:15:22 -05:00
Jim McDonough
30e751c56b r14272: Fix Coverity # 81: free alloc'ed storage before returning 
(This used to be commit 1899d8ea28)
 2007-10-10 11:15:22 -05:00
Jeremy Allison
34e02ea014 r14270: Fix coverity #203. Ensure we free on error exit. 
Jeremy.
(This used to be commit 9fa2e1bded)
 2007-10-10 11:15:22 -05:00
Jeremy Allison
bb0d6f0459 r14268: Fix coverity error #204. Resource leak on error path. 
Jeremy.
(This used to be commit 5f74e56b86)
 2007-10-10 11:15:22 -05:00
Jeremy Allison
88dda37184 r14266: Fix coverity #205. Resource leak on error path. 
Jeremy.
(This used to be commit 23d69758bb)
 2007-10-10 11:15:21 -05:00
Jeremy Allison
65eb331afc r14264: Fix coverity #207. Resource leak on error path. 
Jeremy.
(This used to be commit 0429b6e8c3)
 2007-10-10 11:15:21 -05:00
Jeremy Allison
15603e1c2f r14261: Fix coverity #38. No null deref. 
Jeremy.
(This used to be commit 2a2b966b7b)
 2007-10-10 11:15:21 -05:00
Jeremy Allison
1ab0d76f02 r14259: Fix coverity #42. Ensure contact_domain can't be null derefed 
in error code path.
Jeremy.
(This used to be commit 9f5fcdd8fb)
 2007-10-10 11:15:21 -05:00
James Peach
d245d5c017 r14255: Revert r14204 which was horribly broken. 
(This used to be commit 950ed28f9f)
 2007-10-10 11:15:21 -05:00
Jim McDonough
06f7ee5d4b r14252: Fix Coverity #72: free alloc'ed storage before return. Also found one 
more that coverity didn't find from asprintf.
(This used to be commit 37b6e2c8de)
 2007-10-10 11:15:21 -05:00
Jeremy Allison
05b4d0b38e r14250: Fix coverity bug #107. Resource leak on error path. 
Jeremy.
(This used to be commit ca96c7be77)
 2007-10-10 11:15:20 -05:00
Volker Lendecke
f04579aaf8 r14249: We've dereferenced the_acl before, no point in checking. 
Fix Coverity bug # 128.

Volker
(This used to be commit 84e9e73f3c)
 2007-10-10 11:15:20 -05:00
Volker Lendecke
b84029452b r14248: Fix Coverity bug # 84 
(This used to be commit 811ae2b21f)
 2007-10-10 11:15:20 -05:00
Volker Lendecke
db249de135 r14247: Fix Coverity bug # 136 
(This used to be commit 1b247ff2ed)
 2007-10-10 11:15:20 -05:00
Volker Lendecke
0837f6b584 r14246: Fix Coverity bug # 85 
(This used to be commit ebc21336d8)
 2007-10-10 11:15:20 -05:00
Volker Lendecke
8790a2e257 r14245: We've dereferenced argv before, no point in checking. 
Fix Coverity bug # 144.

Volker
(This used to be commit d47ee82f06)
 2007-10-10 11:15:20 -05:00
Volker Lendecke
15f4c6372c r14244: Okay, had not seen that this happened twice. 
Fix Coverity bug # 142.

Volker
(This used to be commit f2a24b63e3)
 2007-10-10 11:15:20 -05:00
Volker Lendecke
e2e3c377a3 r14243: Fix Coverity bug # 143 
(This used to be commit 5a0087e636)
 2007-10-10 11:15:20 -05:00
Volker Lendecke
1c66bcef8d r14242: Fix Coverity bug # 82 
(This used to be commit 9f645e9962)
 2007-10-10 11:15:19 -05:00
Volker Lendecke
784cc042cb r14241: Fix Coverity bug # 146 
(This used to be commit 97789ec8fc)
 2007-10-10 11:15:19 -05:00
Volker Lendecke
6a8432833b r14236: Fix Coverity bug # 90 
(This used to be commit 019dff53f9)
 2007-10-10 11:15:19 -05:00