1
0
mirror of https://github.com/samba-team/samba.git synced 2025-12-14 20:23:54 +03:00
Commit Graph

5 Commits

Author SHA1 Message Date
Stefan Metzmacher
0523ad2493 r19135: fix bugs...
- passing mem_ctx as ldb_context is a bad idea!
- naming a static function talloc_ is also bad and misleading

metze
2007-10-10 12:15:15 -05:00
Volker Lendecke
26f2cb71eb r19132: Fix some C++ warnings. Is there interest to have them in Samba4 as well?
I have some problems resolving the last 3 ones in attrib_handlers.c. In line
251 the function ldb_dn_explode_casefold is called with mem_ctx as the first
argument. Looking at ldb_dn_explode_casefold I see that the first argument it
expects is a struct ldb_context. I could certainly add a cast to (struct
ldb_context *) to that call, but I would assume that this is the wrong fix. Is
it possible that attrib_handlers.c:251 and :254 should have ldb and not
mem_ctx as the first argument?

Can anybody from Samba4 clarify this for me and apply the correct fix?

Thanks a lot.

Volker
2007-10-10 12:15:15 -05:00
Stefan Metzmacher
63e5727471 r18901: try to fix the samba3 build without having ldap
vl: you were a few seconds faster than me...:-)

metze
2007-10-10 12:14:44 -05:00
Volker Lendecke
d0eef2f6e8 r18900: Next attempt to fix the Solaris build. Not sure about whether to merge this
one. Tridge? Metze?

Volker
2007-10-10 12:14:44 -05:00
Andrew Tridgell
bbedf2e343 r18866: Jeremy and Volker have given the go-ahead on the group mapping ldb
code. Yay!

This first commit copies lib/ldb/ from Samba4. A huge congratulations
should go to Simo on this - he has put an enormous amount of work into
ldb, and it's great to see it go into the Samba3 tree.
2007-10-10 12:14:36 -05:00